Refactor: FsColorThreshold effect source code#39
Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Draft
Refactor: FsColorThreshold effect source code#39google-labs-jules[bot] wants to merge 1 commit intomainfrom
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This commit refactors the source code for the FsColorThreshold effect. - Removes unnecessary comments and translates all Japanese comments into English. - Replaces traditional include guards with `#pragma once`. - Wraps include blocks with `// clang-format off/on` to preserve order. - Applies clang-format to the entire directory for consistent styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the source code within the
Source/Effects/FsColorThresholddirectory.The following changes were made:
#pragma onceinstead of the older#ifndef/#definepattern.#includeblocks with// clang-format offand// clang-format onto prevent the formatter from reordering them.clang-formatfor this directory by modifying.clang-format-ignore.clang-formatto all.cppand.hfiles in the directory to ensure consistent code style.