fix(cluster): update cached resetPassword before navigating after admin setup

[Devin-Holland]

Human-Review-Need: 4 @ 7bd97bc

What

After creating the initial admin user, FinishSetup showed the "Login successful" toast but sometimes never left the setup page.

Why

The reset-password mutation PATCHes central-manager's resetPassword flag (awaited, so the server write is confirmed), but nothing updated the react-query cluster cache — router.invalidate() only re-runs route loaders. The subsequent navigate('../') landed on ClusterHome, which routes on cluster.resetPassword from the same [clusterId] query — still cached true until the next 10s poll tick — so its guard bounced the user straight back to finish-setup. Intermittent by poll timing, which is why it reproduced only sometimes.

Change

New markClusterPasswordSet(queryClient, clusterId) helper next to the query flips resetPassword off in the cache; FinishSetup's onSuccess calls it before navigating. Not an optimistic update — the CM write has already succeeded by the time onSuccess runs.

Verification

• 3 new unit tests for the helper (flips the flag preserving other fields; no phantom cache entry when absent; other clusters untouched) — 8/8 in the file, full suite green via the pre-commit hook, tsc -b clean.
• Traced the post-fix interaction with FinishSetup's own !resetPassword guard: both possible destinations (../ and ../sign-in) resolve to the cluster home for a now-connected user, so no new dead-end.

— devain (Claude)

[gemini-code-assist]

Code Review

This pull request introduces a markClusterPasswordSet utility to synchronously update the cached cluster's resetPassword state to false upon successful setup completion, preventing navigation bounces caused by stale polling data. Unit tests have been added to verify this cache update behavior. The feedback suggests explicitly typing the setQueryData call with the Cluster generic to maintain strict type safety and prevent potential TypeScript compilation errors.

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	54.27%	6431 / 11849
🔵	Statements	54.9%	6926 / 12614
🔵	Functions	45.91%	1562 / 3402
🔵	Branches	47.96%	4423 / 9221

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/features/cluster/FinishSetup.tsx	0%	0%	0%	0%	29-185
src/features/cluster/queries/getClusterInfoQuery.ts	50%	100%	60%	50%	7-8, 27

Generated in workflow #1669 for commit d594bfe by the Vitest Coverage Report Action

[kriszyp]

One codex suggestion

_{🤖 Reviewed with Codex}