Feat: better landing - styling and animations#268
Merged
Conversation
…e space, no paddings
…nd backend (ruff) added
There was a problem hiding this comment.
Pull request overview
Updates the frontend landing page styling/animations and aligns some route pages with centralized meta-tag handling, while also adjusting font loading and developer tooling.
Changes:
- Refines Home page hero + feature card styling/animations (new
gradient-bgshapes; feature-card accent bar). - Adds centralized meta for Privacy/Settings and wires
updateMetaTagsinto those routes. - Moves Google Fonts loading to
index.html(and relaxes CSP accordingly) and updates pre-commit hooks to auto-fix formatting.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/utils/meta.ts | Adds privacy + settings entries to pageMeta for consistent meta tag updates. |
| frontend/src/styles/pages.css | Updates home-page styles (gradient background pseudo-elements, feature-card accent bar). |
| frontend/src/routes/Settings.svelte | Applies updateMetaTags for Settings and tweaks layout spacing/hero animation wrapper. |
| frontend/src/routes/Privacy.svelte | Switches to TS + updateMetaTags, removes <svelte:head>, and updates layout/typography. |
| frontend/src/routes/Home.svelte | Renames hero class to gradient-bg, adjusts layout spacing, refines feature-card markup/styles. |
| frontend/src/app.css | Removes Google Fonts @import from CSS. |
| frontend/public/index.html | Adds Google Fonts preconnect + stylesheet link tags. |
| frontend/nginx.conf.template | Updates CSP to allow Google Fonts stylesheet + font origins. |
| .pre-commit-config.yaml | Changes hooks to auto-format (ruff format, ruff --fix, prettier --write). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 71 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/lib/admin/pollWhileVisible.svelte.ts">
<violation number="1" location="frontend/src/lib/admin/pollWhileVisible.svelte.ts:6">
P2: `setInterval` will fire new ticks even if an async `fn` call is still running, which can cause overlapping poll requests and race conditions. Consider scheduling the next tick only after `fn` resolves (e.g., async loop with `setTimeout`) to avoid concurrent executions.</violation>
</file>
<file name="frontend/src/components/editor/OutputPanel.svelte">
<violation number="1" location="frontend/src/components/editor/OutputPanel.svelte:35">
P2: Handle failures from the async dependency loader to avoid unhandled promise rejections and a permanently stuck output panel.</violation>
</file>
<file name="frontend/src/lib/admin/stores/sagasStore.svelte.ts">
<violation number="1" location="frontend/src/lib/admin/stores/sagasStore.svelte.ts:25">
P2: Polling interval no longer updates when refreshRate changes. pollWhileVisible captures intervalMs once, so user updates to refreshRate (bound in AdminSagas.svelte) won’t adjust the timer.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/lib/admin/pollWhileVisible.svelte.ts">
<violation number="1" location="frontend/src/lib/admin/pollWhileVisible.svelte.ts:23">
P2: A single exception from fn will terminate the polling loop permanently because it bubbles out of run() and is swallowed. Wrap the callback in a try/catch (or handle errors) so polling continues after transient failures.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Revamps the landing page UI and animations, improves performance with route code‑splitting and on‑demand dependencies. Optimizes font loading/CSP, updates Privacy/Settings UI and meta tags, and enables safe auto‑formatting in pre‑commit.
UI Improvements
Bug Fixes
Written for commit 719d90c. Summary will update on new commits.