Skip to content

fix: fallback to issue comment API when PR review comment fetch fails #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hais wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fallback to issue comment API when PR review comment fetch fails #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions src/entrypoints/update-comment-link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,31 @@ async function run() {
// GitHub has separate ID namespaces for review comments and issue comments
// We need to use the correct API based on the event type
if (isPullRequestReviewCommentEvent(context)) {
// For PR review comments, use the pulls API
console.log(`Fetching PR review comment ${commentId}`);
const { data: prComment } = await octokit.rest.pulls.getReviewComment({
owner,
repo,
comment_id: commentId,
});
comment = prComment;
isPRReviewComment = true;
console.log("Successfully fetched as PR review comment");
// For PR review comments, try the pulls API first
// But wrap in try-catch because the comment might be a fallback issue comment
// (created when PR review comment reply failed due to pending review)
try {
console.log(`Fetching PR review comment ${commentId}`);
const { data: prComment } = await octokit.rest.pulls.getReviewComment(
{
owner,
repo,
comment_id: commentId,
},
);
comment = prComment;
isPRReviewComment = true;
console.log("Successfully fetched as PR review comment");
} catch (prCommentError) {
// If PR review comment fetch fails (e.g., 404 because it's actually an issue comment),
// fall through to try issue comment API
console.log(
`PR review comment fetch failed (${(prCommentError as Error).message}), will try issue comment API`,
);
}
}

// For all other event types, use the issues API
// For all other event types, or if PR review comment fetch failed, use the issues API
if (!comment) {
console.log(`Fetching issue comment ${commentId}`);
const { data: issueComment } = await octokit.rest.issues.getComment({
Expand Down
Loading