replace WinAudio with sfml SoundStream#7
Open
nivkner wants to merge 4 commits intoHackerPoet:mainfrom
Open
Conversation
|
How do you compile this on linux ? |
|
@splatpope: @nivkner already answered here |
duh, thought this was using the vs build system for some reason guess I'll use this sound implementation for my fork until I manage to get gamma working (I intend to make a PR with a cmake build system and major code refactoring, but I want to at least have the same features as the original before proposing a merge, so this is welcome) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the program already depends on sfml, it can use its audio instead of implementing one from scratch.
the program was tested on linux, where the expected sounds were produced.
since all code in the PR is cross-platform, hopefully this doesn't affect windows.
the changes to the build system were made manually, let me know if i missed something.