Comprehensive codebase analysis: 18 issues created and assigned to Copilot

[Copilot]

Full-spectrum analysis of riksdagsmonitor across quality, architecture, UI/UX, news generation, and security — resulting in 18 actionable GitHub issues, all assigned to Copilot with implementation PRs in progress.

Findings

Quality

• ESLint config (Fix ESLint configuration: undefined @typescript-eslint/naming-convention rule #673→PR#690): @typescript-eslint/naming-convention referenced in inline comments but undefined in config — 2 lint errors
• HTML nesting (Fix invalid HTML nesting in news article template: <p><ul>...</ul></p> #672→PR#691): 4 news articles have invalid <p><ul>...</ul></p> — orphaned </p> after browser auto-closes <p> before block element
• Quality gates disabled (Enable quality gate enforcement: make lint and HTML validation fail builds #674): exit 1 commented out in quality-checks.yml for both ESLint and HTMLHint steps
• HTMLHint not in generation pipeline (Add HTMLHint validation step to news generation workflows #685→PR#703): validation only runs post-merge, not during article generation
• Coverage all: false (Consolidate Python/TypeScript mixed toolchain: migrate Python scripts to TypeScript #679→PR#697): untested files invisible in reports

Architecture

• 5 files exceed 1000 LOC (Decompose large script files exceeding 1000 lines into focused modules #677→PR#695): content-generators.ts at 1764 lines, committees-dashboard.ts at 1666
• Incomplete prebuild (Fix prebuild pipeline: add missing sitemap-html and RSS generation steps #676→PR#693): missing generate-sitemap-html.ts and generate-rss.ts — sitemap.xml gets stale lastmod timestamps
• Mixed toolchain (Enable comprehensive coverage tracking with all: true and identify untested code #680→PR#696): 11 Python scripts alongside 30+ TypeScript files
• No error boundaries (Add centralized error boundary pattern for dashboard components #687→PR#705): one chart failure can crash entire dashboard

UI/UX

• 949 articles, no pagination (Add pagination and search filtering to news index pages #681→PR#701)
• No skip-to-content (Add skip-to-content link and improve keyboard navigation for WCAG 2.1 AA #683→PR#700): WCAG 2.1 AA §2.4.1 gap
• No theme toggle (Add dark/light theme toggle with system preference detection #686→PR#704)
• Render-blocking fonts (Optimize web font loading strategy: preload critical fonts, async non-critical #689→PR#706): 3 families × 4 weights loaded eagerly

News Generation

• Incomplete language coverage (Ensure complete 14-language coverage in all news generation workflows #682→PR#699): latest evening analysis only in 4/14 languages
• No pipeline integration tests (Add end-to-end integration tests for news article generation pipeline #688→PR#707)
• Flat directory at 949 files (Organize news articles into date-based directory structure for scalability #678→PR#698): scaling concern

Security

• egress-policy: audit on 26+ workflow steps (Harden workflow egress policies and pin @playwright/mcp version #675→PR#694): only deploy-s3.yml uses block
• @playwright/mcp@latest unpinned in all 10 news workflows — supply chain risk

No code changes in this PR

This is an analysis-only PR. All 18 issues are tracked independently with Copilot-assigned PRs (#690–#707).

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.