Wagtail: add HTML signal (dom-only misses response-first detection) - #353
Closed
danielserranoh wants to merge 1 commit into
Closed
Wagtail: add HTML signal (dom-only misses response-first detection)#353danielserranoh wants to merge 1 commit into
danielserranoh wants to merge 1 commit into
Conversation
Wagtail matches only via dom selectors ([data-block-key] + media renditions). Response-first / non-headless consumers don't evaluate dom, so Wagtail goes undetected even when the StreamField markup is present. Add an html pattern for the StreamField block key (statically matchable, same signal as the dom [data-block-key] rule). Verified on wagtail.org and torchbox.com.
Author
|
Closing this one. Per the discussion in #352: Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wagtail matches only via
domselectors ([data-block-key]+ media rendition paths). Response-first / non-headless consumers don't evaluatedom, so Wagtail goes undetected even when the StreamField markup is present in the HTML.This adds an
htmlpattern for the StreamField block key — the same signal as the existingdom[data-block-key]rule, but statically matchable:data-block-key="[a-z0-9]{5}"Note: like the existing dom rule, this only appears on pages rendering StreamField blocks.
Test websites:
Assisted by Claude Code.