Skip to content

Wagtail: add HTML signal (dom-only misses response-first detection) - #353

Closed
danielserranoh wants to merge 1 commit into
HTTPArchive:mainfrom
danielserranoh:wagtail-response-first-signals
Closed

Wagtail: add HTML signal (dom-only misses response-first detection)#353
danielserranoh wants to merge 1 commit into
HTTPArchive:mainfrom
danielserranoh:wagtail-response-first-signals

Conversation

@danielserranoh

Copy link
Copy Markdown

Wagtail matches only via dom selectors ([data-block-key] + media rendition paths). Response-first / non-headless consumers don't evaluate dom, so Wagtail goes undetected even when the StreamField markup is present in the HTML.

This adds an html pattern for the StreamField block key — the same signal as the existing dom [data-block-key] rule, but statically matchable:

  • data-block-key="[a-z0-9]{5}"

Note: like the existing dom rule, this only appears on pages rendering StreamField blocks.


Test websites:

Assisted by Claude Code.

Wagtail matches only via dom selectors ([data-block-key] + media renditions).
Response-first / non-headless consumers don't evaluate dom, so Wagtail goes
undetected even when the StreamField markup is present.

Add an html pattern for the StreamField block key (statically matchable, same
signal as the dom [data-block-key] rule). Verified on wagtail.org and torchbox.com.
@danielserranoh

Copy link
Copy Markdown
Author

Closing this one. Per the discussion in #352: html is deprecated and slower, and HTTP Archive runs Wappalyzer with DOM detection — where the existing [data-block-key] dom rule already covers exactly this signal, so the addition is redundant here. It was aimed at response-first consumers that can't evaluate dom; I'll keep it on my side instead.

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant