Skip to content

Add copilot instructions for team review#1393

Open
PasiVuohijoki wants to merge 1 commit into
mainfrom
add-copilot-instructions
Open

Add copilot instructions for team review#1393
PasiVuohijoki wants to merge 1 commit into
mainfrom
add-copilot-instructions

Conversation

@PasiVuohijoki
Copy link
Copy Markdown
Contributor

@PasiVuohijoki PasiVuohijoki commented Mar 26, 2026

Adds copilot-instructions.md into repository. This is the instruction file I've been using for a while now.


This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 1eb4286.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

- `codegen` (GraphQL code generation)
- `test-db-manager` (test DB tooling)
- `timetables-data-inserter` (submodule)
- Prefer workspace-scoped commands (`yarn ws:...`) when possible.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pitäiskö hasura submodule mainita?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lisäsin maininnan

@PasiVuohijoki PasiVuohijoki force-pushed the add-copilot-instructions branch from c67a5bc to 400114e Compare March 27, 2026 07:15
@PasiVuohijoki PasiVuohijoki force-pushed the add-copilot-instructions branch from 400114e to 1eb4286 Compare March 27, 2026 10:12
@jannebe
Copy link
Copy Markdown
Contributor

jannebe commented Apr 16, 2026

.github/copilot-instructions.md line 14 at r2 (raw file):

  - `codegen` (GraphQL code generation)
  - `test-db-manager` (test DB tooling)
  - `timetables-data-inserter` (submodule)

pois, maininta alla riittänee

@jannebe
Copy link
Copy Markdown
Contributor

jannebe commented Apr 16, 2026

.github/copilot-instructions.md line 30 at r2 (raw file):

## 3) Environment and dependencies

- For local backend dependencies, use `./scripts/development.sh` commands (for example `start:deps`, `setup:env`, `setup:test`, `stop`).

tarvitseeko näitä mainita? näitä ei kai pitäisi copilotin joutua ajamaan vaan devaajan kannattanee pitää ympäristöstä huoli? tai mainita ehkä kehoittaa käyttäjää varmistamaan tarvittavien komponenttienajossa olo, jos jokin muutos sellaisia edellyttää?

@jannebe
Copy link
Copy Markdown
Contributor

jannebe commented Apr 16, 2026

.github/copilot-instructions.md line 102 at r2 (raw file):

- The user always makes git commits themselves. Never commit or offer to commit on behalf of the user.
  • never offer to run any git commands that modify remote repositories unless explicitly requested

@jannebe
Copy link
Copy Markdown
Contributor

jannebe commented Apr 16, 2026

.github/copilot-instructions.md line 109 at r2 (raw file):

- Do not rewrite existing scripts when existing `yarn` and `development.sh` flows solve the task.
- Keep generated-file churn minimal; regenerate only when required by changes.
- When uncertain about behavior that depends on running services (Hasura, Docker stack, db seeds), state assumptions and choose the safest minimal change.

When uncertain... ...and verify assumptions from user before implementing changes.

@jannebe
Copy link
Copy Markdown
Contributor

jannebe commented Apr 16, 2026

.github/copilot-instructions.md line 107 at r2 (raw file):

- Do not refactor unrelated areas.
- Do not add new frameworks, state libraries, or architectural patterns without request.
- Do not rewrite existing scripts when existing `yarn` and `development.sh` flows solve the task.

?

Suggestion:

write new

@jannebe
Copy link
Copy Markdown
Contributor

jannebe commented Apr 16, 2026

pari pikku pointtia

Copy link
Copy Markdown
Contributor

@jannebe jannebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jannebe reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on PasiVuohijoki).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants