Skip to content

AB#425 Trafficnow canceled trips and other improvements#5813

Open
hjvuor wants to merge 18 commits into
v3from
trafficnow-v3
Open

AB#425 Trafficnow canceled trips and other improvements#5813
hjvuor wants to merge 18 commits into
v3from
trafficnow-v3

Conversation

@hjvuor
Copy link
Copy Markdown
Contributor

@hjvuor hjvuor commented May 18, 2026

Proposed Changes

  • Changes from AB#425 Canceled trips view for Traffic now #5735 rebased into the v3 branch
  • Include canceled trips
    • These will be refactored in the future when we get needed api changes
  • Style improvements and styles split into multiple files
  • New header graphic
  • Mode icon in filters

use env variable TRAFFIC_NOW_TEST=true to view the new traffic now page
This is still work in progress but merging this will allow for further development on the v3 branch

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@hjvuor hjvuor marked this pull request as ready for review May 20, 2026 12:53
Copy link
Copy Markdown
Contributor

@sharhio sharhio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor improvements needed.

Also, is the "lisätietoja" link supposed to open in the same window? Often external links open in a new window.

Comment thread app/component/trafficnow/styles/tokens.scss Outdated
Comment thread app/component/trafficnow/CanceledTripsModal.js Outdated
Comment thread static/assets/svg-sprite.hsl.svg Outdated
Comment thread static/assets/svg-sprite.hsl.svg Outdated
Comment thread static/assets/svg-sprite.default.svg Outdated
Comment thread app/component/trafficnow/CanceledTripsModal.js Outdated
Comment thread app/component/trafficnow/CanceledTripCard.js Outdated
Comment thread app/component/trafficnow/CanceledTrips.js Outdated
Comment thread app/component/trafficnow/CanceledTripsModal.js Outdated
Comment thread app/component/trafficnow/CanceledTripCard.js Outdated
@hjvuor hjvuor requested a review from sharhio May 22, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants