Skip to content

refactor(effects-manager): replace implicit boolean checks with EffectsState enum in render path (#886)#899

Open
deveshbervar wants to merge 1 commit into
HSF:mainfrom
deveshbervar:refactor/effects-state-render-path-886
Open

refactor(effects-manager): replace implicit boolean checks with EffectsState enum in render path (#886)#899
deveshbervar wants to merge 1 commit into
HSF:mainfrom
deveshbervar:refactor/effects-state-render-path-886

Conversation

@deveshbervar
Copy link
Copy Markdown
Collaborator

Summary

Phase 1 (part 3 of 4) of #886.

Replaces implicit boolean checks in the render path with
typed EffectsState enum comparisons.

What changed

antialiasRender():

// BEFORE
if (this.selectedObjectsSet.size > 0)
else if (this.hoverOutline)

// AFTER
if (this.currentState === EffectsState.SELECTED)
else if (this.currentState === EffectsState.HOVERED)

updateSelectionPulse():

// BEFORE
if (this.selectionOutlinePass && this.selectedObjectsSet.size > 0)

// AFTER
if (this.selectionOutlinePass && this.currentState === EffectsState.SELECTED)

Scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant