feat: animate pileup interactions sequenced by timestamp (#235)#862
Open
deveshbervar wants to merge 1 commit intoHSF:mainfrom
Open
feat: animate pileup interactions sequenced by timestamp (#235)#862deveshbervar wants to merge 1 commit intoHSF:mainfrom
deveshbervar wants to merge 1 commit intoHSF:mainfrom
Conversation
- Add PileupInteraction and PileupEvent types to event-data.ts - Add animatePileup() to AnimationsManager with timestamp-based sequencing - Each interaction fires a vertex flash at its specific (x,y,z) position - Add _animateInteractionTracks() for real per-interaction track animation - Expose animatePileup() through ThreeManager and EventDisplay public API - Add Animate pileup button to animate-event UI component All 179 existing tests passing. Tested on ATLAS sample: 10 sequential vertex flashes visible along beam axis, each separated by ~1 second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
What this adds
Animates multiple pp interactions (pileup) from a single bunch crossing,
sequenced in time order using the timestamp stored on each interaction.
This is the foundational feature needed for HL-LHC precision-timing
detector visualisation in ATLAS and CMS.
Demo
Recording.2026-03-28.143749.mp4
How it works
PileupInteractiontype with timestamp (ps), vertex (x,y,z), tracks and jetsPileupEventtype containing an array of interactionsanimatePileup()sorts interactions by timestamp and maps each to aproportional delay, firing a vertex flash at the exact (x,y,z) position
_animateInteractionTracks()handles per-interaction track animationwhen real tagged track data is provided
Testing
beam axis, each clearly separated by ~1 second
Next steps for real HL-LHC data
Replace synthetic test data in
animate-event.component.tswith realJSON matching the
PileupEventformat:{ "interactions": [ { "timestamp": 0, "vertex": {"x":0,"y":0,"z":-45}, "tracks":[] }, { "timestamp": 32, "vertex": {"x":0,"y":0,"z": 12}, "tracks":[] } ] }