feat: add time-aware EDM support and realistic animations (fixes #406)#822
feat: add time-aware EDM support and realistic animations (fixes #406)#822deveshbervar wants to merge 2 commits intoHSF:mainfrom
Conversation
deveshbervar
commented
Mar 12, 2026
- Add EventTime and EventMetadata interfaces to event-data-loader.ts
- Add optional getEventTime?() to EventDataLoader interface
- Extract event-level time (ns) in PhoenixLoader.buildEventData()
- Forward event time to AnimationsManager
- Add setEventTime(), getTimeProgress(), update() to AnimationsManager
- Add Event Time Progress slider to dat-gui UI
- Add tests for time extraction in phoenix-loader.test.ts
) - Add EventTime and EventMetadata interfaces to event-data-loader.ts - Add optional getEventTime?() to EventDataLoader interface - Extract event-level time (ns) in PhoenixLoader.buildEventData() - Forward event time to AnimationsManager - Add setEventTime(), getTimeProgress(), update() to AnimationsManager - Add Event Time Progress slider to dat-gui UI - Add tests for time extraction in phoenix-loader.test.ts
|
Hi @deveshbervar - sorry for taking so long to review this. I have to admit, I was a bit confused (and remain a bit confused) about that the intention is here. I don't really understand what |
|
Hi @EdwardMoyse, Thanks a lot for the review! What
|