Open
Conversation
Adds Korean as a selectable UI language alongside existing en/zh. Default language is unchanged (en remains the default). Frontend - web/locales/ko/app.json: 859 keys, full parity with en/app.json - web/locales/ko/common.json: matching common namespace - Extended AppLanguage type union with "ko" in i18n init, AppShellContext, lib/datetime, and settings page - Settings language picker now offers English / 中文 / 한국어 - Added ko-KR locale mapping for date formatting - Added "language.korean" label to en/zh common.json for symmetry Backend - UISettings and LanguageUpdate Pydantic Literal extended to accept "ko" (default still "en") - _normalize_language recognizes ko / korean / kr aliases
Collaborator
|
Thanks for your contribution! Howver, DeepTutor is updating frequently nowadays, so i'll try to merge this when our update frequency is lower. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Korean (
ko) as a selectable UI language alongside the existing English (en) and Chinese (zh). The default remainsen— this PR only adds Korean as an option for users who want it.Hi maintainers! I'm a Korean user who has been enjoying DeepTutor. I translated the entire UI into Korean and would love to contribute it upstream so other Korean users can benefit. Happy to iterate on wording or style if you have preferences.
Changes
Frontend (
web/)locales/ko/app.json— 859 keys, full parity withen/app.jsonlocales/ko/common.jsonAppLanguagetype union with"ko"ini18n/init.ts,context/AppShellContext.tsx,lib/datetime.ts, and the settings pageko-KRlocale mapping inlib/datetime.tslanguage.koreanlabel toen/common.jsonandzh/common.jsonfor symmetryBackend (
deeptutor/)UISettingsandLanguageUpdatePydanticLiteralextended to accept"ko"(default still"en")_normalize_languagerecognizesko/korean/kraliasesTranslation notes
zh/app.jsonconvention of translating feature names (e.g., Deep Solve → 딥 솔브, Vision Solver → 비전 솔버, Co-Writer → 코라이터, Playground → 플레이그라운드)en/app.jsonvia a parity check scriptnpx tsc --noEmitpasses cleanly inweb/Test plan
en/zhremain unaffectedGET /api/v1/settings/uiandPUT /api/v1/settings/uiaccept"ko"