This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Closed
Conversation
Author
|
Closing this since #293 is already addressing this issue 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're using node-hubspot as a part of a NextJS with Typescript. NextJS enforces use of
isolatedModuleswith TS. And the TS compiler threw this error when we tried to build after addinghubspot:This change addresses the need by:
Adding
typeto the export statement infile.tsContributing guidelines
npm run buildThank you for the work you're doing on this package! 🙏