Open
Conversation
Update tests to use geometry files from k4geo, rather than the obsolete ones in FCCDetectors. The old ones fail due to errors in the type_flags elements. These were previously not failing because dd4hep was hiding the errors. However, a side effect of this change AIDASoft/DD4hep#1578 is that dd4hep is properly reporting the errors. Also, run the ubuntu build only with the nightly on ubuntu24.
This was referenced Mar 9, 2026
Contributor
|
Since I just ran into similar failures in a different context. Can you tell me how this fixes issues with the type flags? This seems to only change detector models, but it doesn't touch any xml file. What am I missing here? |
Author
|
The DetType_ symbols are defined in the file detector_types.xml from DD4hep. This should be included from the top-level detector xml files, but this was not the case for most of the configurations in FCCDetectors. The versions in k4geo do however do this. Since the maintained versions are now the ones in k4geo, it seemed better to switch to using those versions rather than try to fix the ones in FCCDetectors. |
Contributor
|
Ah, alright. That makes sense. Thanks a lot for the explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests to use geometry files from k4geo, rather than the obsolete ones in FCCDetectors. The old ones fail due to errors in the type_flags elements. These were previously not failing because dd4hep was hiding the errors. However, a side effect of this change
AIDASoft/DD4hep#1578
is that dd4hep is properly reporting the errors.
Also, run the ubuntu build only with the nightly on ubuntu24.