feat: add tax withholding explanations and off-cycle disclaimer note - #2618
Draft
krisxcrash wants to merge 2 commits into
Draft
feat: add tax withholding explanations and off-cycle disclaimer note#2618krisxcrash wants to merge 2 commits into
krisxcrash wants to merge 2 commits into
Conversation
Adds a "taxed as" supporting-text slot to WageTypeGroup so hosts can explain how each wage type category is taxed, and surfaces the standard off-cycle payroll tax-impact disclaimer (matching the copy already shown in the existing off-cycle payroll UI) above the tax withholding table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taxedAsDescriptionfield toWageTypeGroup, rendered as supporting text under the derived "taxed as" value inOffCycleTaxWithholdingTable(mirrors the existingdescriptionfield already shown under the wage-type label).Payroll.OffCycleTaxWithholdingi18n namespace and wires it intoOffCycleCreationPresentation'swageTypeGroups.OffCycleCreationPresentation, using the same copy already shown in the existing off-cycle payroll UI (gws-flows), rendered via<Trans>for the inline-bold segment.There was previously no way for a
OffCycleTaxWithholdingTableconsumer to explain how a wage type category is taxed, and no disclaimer that off-cycle payrolls can affect tax withholding when relied on exclusively.Test plan
npm run test -- --run— full suite passes (3824 passed, 1 pre-existing expected fail)npx tsc --noEmit— no errorsnpm run lint— 0 errors, only pre-existing warningsnpm run i18n:generate— regeneratedsrc/i18n/types.d.tsand committedOffCycleTaxWithholdingTable.test.tsxandOffCycleCreation.test.tsxOffCycleTaxWithholdingTable.stories.tsxwith the newtaxedAsDescriptioncopy🤖 Generated with Claude Code