[SDK-1171] Fix payroll review actions at narrow widths - #2608
Draft
hukid wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Payroll Overview at narrow reflow widths by keeping the unprocessed payroll Edit and Submit actions in one shrink-safe, equal-width row. The change preserves heading-first semantic order, desktop behavior, submission state and callbacks, while leaving processed payroll receipt/cancel actions stacked for their longer labels.
Changes
minmax(0, 1fr)tracks for unprocessed base/mobile actions while retaining a single track for processed payroll actions.320x256Storybook regression story using the existing wire-funds fixture.Demo
Chromium verification at an exact
320x256inspection region showed no horizontal overflow. Edit and Submit render on the same row at156x40each, both remain operable, the heading precedes the actions, and all later content is vertically reachable. The blocked state and the639px/640pxbreakpoint transition were also verified.Safari with VoiceOver was not available in the execution environment. That browser and assistive-technology combination remains a manual verification item before merge.
Related
Testing
npm run test -- --run --exclude '.claude/**' src/components/Payroll/PayrollOverview/PayrollOverviewPresentation.test.tsx- 32/32 passing after synchronization withorigin/main.npm run tsc,npm run build,npm run build-storybook, scoped ESLint/Prettier, and diff checks passed during implementation verification..claude/worktrees: 3,736 passing, 1 expected failure, and 5 unrelated date/time-boundary failures in untouched files.320x256: no horizontal overflow; Edit and Submit each measured156x40, shared one row, remained operable, and followed the heading in semantic order.639pxand640px: no duplicate or missing action group across the base/desktop breakpoint. The blocked Submit state remained visible and disabled, and processed mobile actions remained stacked.320x256reflow, focus order, accessible names, disabled state, and vertical reachability in Safari with VoiceOver.