fix(ContractorPayments): restore hours input typing + live hint updates#2262
Open
aaronlee777 wants to merge 1 commit into
Open
fix(ContractorPayments): restore hours input typing + live hint updates#2262aaronlee777 wants to merge 1 commit into
aaronlee777 wants to merge 1 commit into
Conversation
The previous refactor attached an onChange handler directly to the <Input> slot inside react-aria's <NumberField>, which replaced react-aria's own context-injected handler. Typed characters never reached the field's displayed state and the cached hint stayed stale on arrow-key commits. Move the onChange callback up onto <Group> so React's synthetic-event bubbling observes the same change events without overriding react-aria's handler, and drive the hint from a useState<number> fed by onInputChange (live typing) + onChange (arrow keys / step buttons). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onChangehandler directly to the<Input>slot insidereact-aria's<NumberField>, which replaced react-aria's context-injected handler that controls the displayed text and value commits.onChangecallback up onto<Group>so React's synthetic-event bubbling observes the same events without overriding react-aria's handler. Drive the hint from auseState<number>fed byonInputChange(per-keystroke) +onChange(arrow keys / step buttons).<Input>is back under react-aria's control.Test plan
hoursreaches the payload unchanged.NumberInputstory — no dropped characters.🤖 Generated with Claude Code