Skip to content

test: verify migrate-success warnings handling (v2026-02-01)#2237

Closed
jeffredodd wants to merge 0 commit into
upgrade/api-2026-02-01-basefrom
upgrade/api-2026-02-01/migrate-warnings
Closed

test: verify migrate-success warnings handling (v2026-02-01)#2237
jeffredodd wants to merge 0 commit into
upgrade/api-2026-02-01-basefrom
upgrade/api-2026-02-01/migrate-warnings

Conversation

@jeffredodd

Copy link
Copy Markdown
Contributor

Summary

⚠️ Sub-PR off #2233 (the v2026-02-01 base bump).

v2026-02-01 adds a warnings[] array to migrate-success responses. The migrate flow is partner-driven; no SDK component in src/ currently consumes the migrate-success response shape, so this is verify-only at the SDK layer.

Changes

  • e2e/tests/company/04-migrate-warnings-handling.spec.ts (new): asserts the SDK doesn't choke when migrate-success carries a warnings[] array.

Currently test.skip — un-skip once we have a Demo scenario that provisions a fresh pre-migration company (tracked alongside SDK-999).

Open follow-up

If we later decide to surface warnings to partners (e.g. a hook return value or a toast), that's a separate feature PR — not part of this bump.

References

Test plan

  • CI green after the base PR's dep bump
  • Stage a fresh pre-migration scenario and un-skip the spec
  • Decide on partner-facing warnings surfacing (separate PR)

🤖 Generated with Claude Code

@jeffredodd jeffredodd closed this Jun 23, 2026
@jeffredodd jeffredodd force-pushed the upgrade/api-2026-02-01/migrate-warnings branch from 6ff969a to b968432 Compare June 23, 2026 16:14
@jeffredodd

Copy link
Copy Markdown
Contributor Author

Superseded by the base PR #2233 — the E2E scaffold for this breaking change was moved onto the base branch so the upgrade-base CI shows the verification trail directly (per Jeff's review-flow ask). This sub-PR's diff is now empty and can be closed; no further SDK code change was needed for this breaking change.

@jeffredodd jeffredodd deleted the upgrade/api-2026-02-01/migrate-warnings branch June 24, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant