Skip to content

test: verify migration_status string→boolean (v2026-02-01)#2236

Closed
jeffredodd wants to merge 0 commit into
upgrade/api-2026-02-01-basefrom
upgrade/api-2026-02-01/migration-status
Closed

test: verify migration_status string→boolean (v2026-02-01)#2236
jeffredodd wants to merge 0 commit into
upgrade/api-2026-02-01-basefrom
upgrade/api-2026-02-01/migration-status

Conversation

@jeffredodd

Copy link
Copy Markdown
Contributor

Summary

⚠️ Sub-PR off #2233 (the v2026-02-01 base bump).

v2026-02-01 changes migration_status on Company endpoints from a string enum to a boolean. No SDK component currently reads this field (grep -rn migrationStatus src/ returns zero hits), so this is a verify-only bump.

Changes

  • e2e/tests/company/03-migration-status-boolean.spec.ts (new): loads the onboarded-company surface (which carries migration_status in its response) and asserts no narrowing-on-string crash. If we missed a consumer of the old string shape, this fails.

References

Test plan

  • CI green after the base PR's dep bump
  • Spec passes against Demo (negative: indicates no missed consumer)
  • Optional: extend the assertion to read migration_status off a tracked response if a partner-facing surface ever consumes it

🤖 Generated with Claude Code

@jeffredodd jeffredodd closed this Jun 23, 2026
@jeffredodd jeffredodd force-pushed the upgrade/api-2026-02-01/migration-status branch from 9aa7d4c to b968432 Compare June 23, 2026 16:14
@jeffredodd

Copy link
Copy Markdown
Contributor Author

Superseded by the base PR #2233 — the E2E scaffold for this breaking change was moved onto the base branch so the upgrade-base CI shows the verification trail directly (per Jeff's review-flow ask). This sub-PR's diff is now empty and can be closed; no further SDK code change was needed for this breaking change.

@jeffredodd jeffredodd deleted the upgrade/api-2026-02-01/migration-status branch June 24, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant