test: verify self-onboarding email requirement (v2026-02-01)#2235
Closed
jeffredodd wants to merge 0 commit into
Closed
test: verify self-onboarding email requirement (v2026-02-01)#2235jeffredodd wants to merge 0 commit into
jeffredodd wants to merge 0 commit into
Conversation
6d41d5a to
b968432
Compare
Contributor
Author
|
Superseded by the base PR #2233 — the E2E scaffold for this breaking change was moved onto the base branch so the upgrade-base CI shows the verification trail directly (per Jeff's review-flow ask). This sub-PR's diff is now empty and can be closed; no further SDK code change was needed for this breaking change. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2026-02-01 makes
emaila server-required field on self-onboarding employee-create. The SDK's Zod schema already enforces this client-side (buildFormSchema.test.ts:382-412), so the bump is verify-only at the SDK layer — no production code change.Changes
e2e/tests/employee/04-self-onboarding-email-required.spec.ts(new): drives the self-onboarding profile form without filling email and asserts the client-side validation surfaces before the request is sent.Currently
test.skippending a scenario that provisions a fresh self-onboarding employee from scratch. The assertion shape is in place so the implementation has a target.What we expect post-upgrade
buildFormSchema.test.tscontinues to enforce email-required on self-onboarding submit.92-self-onboarding-submit.spec.tscontinues to pass against Demo.04-self-onboarding-email-required.spec.tsproves the new contract via the negative case.References
Test plan
buildFormSchema.test.tsgreen after the base PR's dep bump92-self-onboarding-submit.spec.tsstill green against Demo04-self-onboarding-email-required.spec.ts🤖 Generated with Claude Code