Skip to content

test: verify self-onboarding email requirement (v2026-02-01)#2235

Closed
jeffredodd wants to merge 0 commit into
upgrade/api-2026-02-01-basefrom
upgrade/api-2026-02-01/self-onboarding-email
Closed

test: verify self-onboarding email requirement (v2026-02-01)#2235
jeffredodd wants to merge 0 commit into
upgrade/api-2026-02-01-basefrom
upgrade/api-2026-02-01/self-onboarding-email

Conversation

@jeffredodd

Copy link
Copy Markdown
Contributor

Summary

⚠️ Sub-PR off #2233 (the v2026-02-01 base bump).

v2026-02-01 makes email a server-required field on self-onboarding employee-create. The SDK's Zod schema already enforces this client-side (buildFormSchema.test.ts:382-412), so the bump is verify-only at the SDK layer — no production code change.

Changes

  • e2e/tests/employee/04-self-onboarding-email-required.spec.ts (new): drives the self-onboarding profile form without filling email and asserts the client-side validation surfaces before the request is sent.

Currently test.skip pending a scenario that provisions a fresh self-onboarding employee from scratch. The assertion shape is in place so the implementation has a target.

What we expect post-upgrade

  • buildFormSchema.test.ts continues to enforce email-required on self-onboarding submit.
  • Existing 92-self-onboarding-submit.spec.ts continues to pass against Demo.
  • New 04-self-onboarding-email-required.spec.ts proves the new contract via the negative case.

References

Test plan

  • buildFormSchema.test.ts green after the base PR's dep bump
  • 92-self-onboarding-submit.spec.ts still green against Demo
  • Stage a fresh-self-onboarding scenario and un-skip 04-self-onboarding-email-required.spec.ts

🤖 Generated with Claude Code

@jeffredodd jeffredodd closed this Jun 23, 2026
@jeffredodd jeffredodd force-pushed the upgrade/api-2026-02-01/self-onboarding-email branch from 6d41d5a to b968432 Compare June 23, 2026 16:14
@jeffredodd

Copy link
Copy Markdown
Contributor Author

Superseded by the base PR #2233 — the E2E scaffold for this breaking change was moved onto the base branch so the upgrade-base CI shows the verification trail directly (per Jeff's review-flow ask). This sub-PR's diff is now empty and can be closed; no further SDK code change was needed for this breaking change.

@jeffredodd jeffredodd deleted the upgrade/api-2026-02-01/self-onboarding-email branch June 24, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant