feat: handle migration_blocker / migration_warning categories (v2026-02-01)#2234
Closed
jeffredodd wants to merge 1 commit into
Closed
feat: handle migration_blocker / migration_warning categories (v2026-02-01)#2234jeffredodd wants to merge 1 commit into
jeffredodd wants to merge 1 commit into
Conversation
…02-01) 🔴 Sub-PR off #2233. Adds the decision and verification scaffold for the new migration_blocker / migration_warning categories introduced in @gusto/embedded-api-v-2026-02-01. Decision: do NOT extend PAYROLL_RESOLVABLE_SUBMISSION_BLOCKER_TYPES. The existing GenericBlocker fallback at PayrollOverviewPresentation.tsx:668 and PreviewPresentation.tsx:140 already renders unknown blocker types gracefully and disables submit. The new categories are informational (not partner-resolvable), so the fallback is correct. Decision is documented inline on the whitelist for future maintainers. E2E coverage: 06-migration-blocker-rendering.spec.ts asserts the GenericBlocker fallback path renders + disables submit. Currently test.skip pending a Demo scenario provisioning a company in mid-migration state — tracked alongside SDK-999. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jeffredodd
force-pushed
the
upgrade/api-2026-02-01/migration-blockers
branch
from
a5d2e91 to
7c777d8
Compare
4 tasks
Contributor
Author
|
Closing: this PR's analysis was based on a conflation between two different blocker concepts. The new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🔴 Sub-PR off #2233 (the v2026-02-01 base bump).
v2026-02-01 introduces
migration_blockerandmigration_warningblocker categories. This PR captures the decision to NOT extend the resolvable-blocker whitelist for these — the existing<GenericBlocker>fallback at both render sites handles unknown types gracefully and disables submit, which is the correct behavior for informational (non-partner-resolvable) blockers.Changes
src/shared/constants.ts: documents the decision inline onPAYROLL_RESOLVABLE_SUBMISSION_BLOCKER_TYPES. No runtime change.e2e/tests/payroll/06-migration-blocker-rendering.spec.ts(new): scaffolds an E2E assertion that GenericBlocker renders + submit is disabled for unknown blocker types. Currentlytest.skip— needs a Demo company provisioned in a mid-migration state to actually exercise. Tracked alongside SDK-999.Revisit triggers
Open the whitelist back up if SDK-999 testing reveals:
MigrationBlockerBannercomponentReferences
PayrollOverviewPresentation.tsx:668,PreviewPresentation.tsx:140Test plan
06-migration-blocker-rendering.spec.ts🤖 Generated with Claude Code