Migrate from ExoPlayer 2.x to AndroidX Media3#207
Open
dipenpradhan wants to merge 8 commits into
Open
Conversation
- Replace kotlin-kapt with com.google.devtools.ksp in the app module
and the common-kotlin convention plugin
- Add Room compiler via the ksp configuration instead of kapt
- Drop the kapt { correctErrorTypes = true } workaround
- Add symbol-processing-gradle-plugin (1.9.22-1.0.17) to buildSrc
Fixes Gurupreet#184
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Bump kotlin-gradle-plugin 1.9.22 -> 2.1.20 (root + buildSrc) - Adopt the new Compose Compiler Gradle plugin (org.jetbrains.kotlin.plugin.compose) in app and convention plugins - Drop composeCompiler version constant and composeOptions blocks - Replace removed -Xopt-in flag with -opt-in - Bump KSP to 2.1.20-1.0.31 to match Kotlin Fixes Gurupreet#182 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ktfmt-gradle 0.12.0 fails with 'Generic error during file processing' once Kotlin 2.x is on the buildscript classpath. 0.22.0 supports Kotlin 2.x and also formats *.kts build scripts, hence the repo-wide reformat (no functional changes). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- AGP 8.2.2 -> 8.7.3 (compileSdk 35 supported from AGP 8.6) - Gradle wrapper 8.5 -> 8.9 (required by AGP 8.7.x) Fixes Gurupreet#185 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Replace compose/material3 version constants with composeBom - Strip explicit versions from BOM-managed artifacts - Import the BOM platform on every configuration that receives Compose artifacts (implementation, debugImplementation, androidTestImplementation, :data) - Migrate API removals that come with Compose 1.7 / Material3 1.3: SmallTopAppBar -> TopAppBar, rememberRipple -> material3 ripple - Update the outdated README Compose badge to the BOM version Fixes Gurupreet#186 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
All lifecycle artifacts (viewmodel-compose, viewmodel-ktx, livedata-ktx, runtime-ktx, viewmodel-savedstate) move together via the shared androidLifecycleGrouped version. Fixes Gurupreet#192 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- navCompose 2.7.7 -> 2.8.9; add kotlinx-serialization-json 1.8.0 - Apply the Kotlin serialization plugin in gmail and tiktok demos - Gmail: string routes -> @serializable route objects - TikTok: TikTokScreen becomes a serializable sealed interface; the profile route carries a typed userId argument read via toRoute(), bottom bar selection uses NavDestination.hasRoute Fixes Gurupreet#193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Replace com.google.android.exoplayer:exoplayer with androidx.media3:media3-exoplayer and media3-ui - Rewrite TikTokPlayer against the Media3 API (SimpleExoPlayer was removed; default media source factory handles asset URIs) - Removes the last Jetifier warning produced by ExoPlayer 2.x Fixes Gurupreet#183 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates from the deprecated ExoPlayer 2.x to AndroidX Media3 1.5.1, as proposed in #183.
com.google.android.exoplayer:exoplayer:2.19.1→androidx.media3:media3-exoplayer+androidx.media3:media3-uiVersions.kt:exoplayerconstant replaced withmedia3TikTokPlayer.kt(the only ExoPlayer consumer in the codebase — the YouTube demo doesn't actually use ExoPlayer) rewritten against Media3:SimpleExoPlayer(removed in Media3) →ExoPlayer.BuilderProgressiveMediaSource/DefaultDataSourceFactorywiring dropped in favor ofsetMediaItem— the default media source factory resolvesasset:///URIsandroidx.media3.*;@OptIn(UnstableApi::class)forPlayerView/resizeModeAs a bonus, Media3 is AndroidX-native, removing the last Jetifier warning that ExoPlayer 2.x produced during builds.
Closes #183
Verification
./gradlew ktfmtCheck assembleDebug testDebugUnitTestpasses locally (JDK 17, SDK 35)t1.mp4–t3.mp4); the player wiring is unchanged apart from the API rename./gradlew buildon this PRMerge order
PR 7 of the stacked series. Depends on #195 → #196 → #197 → #204 → #205 → #206 — its diff includes their commits until they merge.
🤖 Generated with Claude Code
cc @Gurupreet for review