Coalesce Base Predicate counts + information into record and make MultiPredicate have counts - #5342
Draft
ghzdude wants to merge 8 commits into
Draft
Coalesce Base Predicate counts + information into record and make MultiPredicate have counts#5342ghzdude wants to merge 8 commits into
ghzdude wants to merge 8 commits into
Conversation
add set settings copy settings
YoungOnionMC
requested changes
Aug 24, 2026
| } | ||
|
|
||
| @CheckReturnValue | ||
| public MultiPredicate setMinCount(int min) { |
Member
There was a problem hiding this comment.
can we add a bool if the min and max counts should be applied to children?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Multipredicates should now be able to be treated like base predicates for testing min/max counts
Implementation Details
Added record
PredicateSettingswhich combines several of BasePredicate's fieldsMultiPredicate also has a settings field, though it is nullable unlike in BasePredicate
For MultiPredicates, if
settings == nullthey behave exactly as before.When
settingsis nonnull, it also gets checked along with children predicatesboth must be
trueto passLang has also been introduced for the to-be-used recipe view tooltips
AI Usage
Outcome
you should be able to do
a.or(b).setMinCount(4)to mean "4 combined of either predicates" nowHow Was This Tested
ran client, only check the assembly line which formed as expected