Plungers empty Fluid Pipes - #5332
Open
DilithiumThoride wants to merge 2 commits into
Open
Conversation
DilithiumThoride
added
type: bugfix
htmlcsjs
approved these changes
Aug 22, 2026
ghzdude
reviewed
Aug 22, 2026
YoungOnionMC
approved these changes
Aug 24, 2026
Member
|
want @Ghostipedia to look at this before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Plungers didn't empty fluid pipes. Now they do.
Implementation Details
The only current place Plunger Behavior is currently defined is inside PlungerBehavior, which covers the cases for a standard GTM machine, a Forge machine with a fluid handler, and any machine or slot that can take a Bucket interaction. However, GTM Fluid Pipes are none of those.
To deal with this I did an override of onToolClick specifically on FluidPipeBlockEntity. The Plunger action is checked last, after the normal crowbar/wrench/PipeTune checks.
For quad and nonuple fluid pipes, all pipes in the block are vented at once.
AI Usage
Outcome