Conversation
…ation Implements full ESPI 4.0 compliance for Meter resource per customer.xsd. Changes: - Extracted shared embeddables to domain/customer/common/: * ElectronicAddress (customer.xsd lines 886-936) * StreetAddress (customer.xsd lines 1285-1320) * TelephoneNumber (customer.xsd lines 1428-1478) * MeterMultiplier (customer.xsd MeterMultiplier type) - MeterEntity: Added meterMultipliers @ElementCollection - MeterDto: Added 19 XSD-compliant fields including meterMultipliers - MeterMultiplierDto: New DTO for meter multiplier collection - MeterMapper: MapStruct mapper with UUID v5 generation - MeterService: Simplified to 6 CRUD methods (ESPI 4.0 pattern) - MeterRepository: Removed 11 non-ID query methods - Flyway V3: Added meter_multipliers collection table - TestDataBuilders: Added createValidMeter() helper - Tests: 16 unit tests + 18 integration tests (MySQL/PostgreSQL) - BigDecimal assertions: Use isEqualByComparingTo() for cross-platform precision - CLAUDE.md: Added file modification best practices (NEVER use sed/awk) Updated entities to use extracted embeddables: - Organisation, Asset, Location, CustomerEntity, CustomerAccountEntity, CustomerAgreementEntity, EndDeviceEntity, OrganisationRole, ServiceLocationEntity and all related mappers and tests All 736 tests passing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements full ESPI 4.0 compliance for the Meter resource per customer.xsd specification.
Key Changes
New Shared Embeddables (domain/customer/common/):
Meter Implementation:
Refactoring:
Testing:
Documentation:
Test Plan
Files Changed
🤖 Generated with Claude Code