Collectors: skip appending a transaction marker for fleet metadata updates#25542
Collectors: skip appending a transaction marker for fleet metadata updates#25542
Conversation
kroepke
left a comment
There was a problem hiding this comment.
I was wondering whether it makes sense to create a marker when we create the fleet (line https://github.com/Graylog2/graylog2-server/pull/25542/changes#diff-b8b0f61319e372de23353023a5c78a0973f0bb1e805b1835377c5602cdc8e6bcL113)?
I'm not sure whether we could have a situation where that would cause anything at all:
- can collectors even enroll in non-existing fleets?
- the fleet would be empty anyway
- no existing assignments should be there
Yeah, I don't see how the creation of a new fleet could affect collector config. I can remove it as well in this PR, if this is what you are suggesting? |
Mostly an open question. I think it doesn't do any harm if we leave it in: i think it's basically a no-op |
None of the fleet attribute in the update path are currently relevant for the generated config that is pushed to collectors. Therefore, we skip appending a transaction marker.
Resolves #25306
/nocl