Skip to content

Collectors: skip appending a transaction marker for fleet metadata updates#25542

Open
thll wants to merge 1 commit intomasterfrom
skip-txn-marker-for-fleet-updates
Open

Collectors: skip appending a transaction marker for fleet metadata updates#25542
thll wants to merge 1 commit intomasterfrom
skip-txn-marker-for-fleet-updates

Conversation

@thll
Copy link
Copy Markdown
Contributor

@thll thll commented Apr 2, 2026

None of the fleet attribute in the update path are currently relevant for the generated config that is pushed to collectors. Therefore, we skip appending a transaction marker.

Resolves #25306

/nocl

@thll thll added the collector label Apr 2, 2026
@thll thll requested a review from a team April 2, 2026 08:42
Copy link
Copy Markdown
Member

@kroepke kroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering whether it makes sense to create a marker when we create the fleet (line https://github.com/Graylog2/graylog2-server/pull/25542/changes#diff-b8b0f61319e372de23353023a5c78a0973f0bb1e805b1835377c5602cdc8e6bcL113)?

I'm not sure whether we could have a situation where that would cause anything at all:

  1. can collectors even enroll in non-existing fleets?
  2. the fleet would be empty anyway
  3. no existing assignments should be there

@thll
Copy link
Copy Markdown
Contributor Author

thll commented Apr 2, 2026

I was wondering whether it makes sense to create a marker when we create the fleet (line https://github.com/Graylog2/graylog2-server/pull/25542/changes#diff-b8b0f61319e372de23353023a5c78a0973f0bb1e805b1835377c5602cdc8e6bcL113)?

I'm not sure whether we could have a situation where that would cause anything at all:

  1. can collectors even enroll in non-existing fleets?
  2. the fleet would be empty anyway
  3. no existing assignments should be there

Yeah, I don't see how the creation of a new fleet could affect collector config. I can remove it as well in this PR, if this is what you are suggesting?

@kroepke
Copy link
Copy Markdown
Member

kroepke commented Apr 2, 2026

I was wondering whether it makes sense to create a marker when we create the fleet (line https://github.com/Graylog2/graylog2-server/pull/25542/changes#diff-b8b0f61319e372de23353023a5c78a0973f0bb1e805b1835377c5602cdc8e6bcL113)?
I'm not sure whether we could have a situation where that would cause anything at all:

  1. can collectors even enroll in non-existing fleets?
  2. the fleet would be empty anyway
  3. no existing assignments should be there

Yeah, I don't see how the creation of a new fleet could affect collector config. I can remove it as well in this PR, if this is what you are suggesting?

Mostly an open question. I think it doesn't do any harm if we leave it in: i think it's basically a no-op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata updates on fleets should not trigger complete reconfiguration

2 participants