Skip to content

Fix issue when first time adds favorite fields and default fav fields disappear#25530

Open
maxiadlovskii wants to merge 7 commits intomasterfrom
fix/issue-25517
Open

Fix issue when first time adds favorite fields and default fav fields disappear#25530
maxiadlovskii wants to merge 7 commits intomasterfrom
fix/issue-25517

Conversation

@maxiadlovskii
Copy link
Copy Markdown
Contributor

@maxiadlovskii maxiadlovskii commented Apr 1, 2026

Description

We use default fields to set favorite fields when the user doesn't have them yet.
This PR also filters default fields when they don't exist in the message, to align what user see on the screen with what we sending as favorite to BE

Motivation and Context

fix: #25517

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

/jpd https://github.com/Graylog2/e2e-tests/pull/1554

@maxiadlovskii maxiadlovskii requested a review from linuspahl April 1, 2026 11:31
@maxiadlovskii maxiadlovskii added the e2e-tests Run PR build with e2e tests. label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the described issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tests Run PR build with e2e tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Favorite fields: Default favorite fields disappear after adding favorite field

2 participants