Skip to content

Fix name of datanode in-memory internal appender#25521

Open
todvora wants to merge 2 commits intomasterfrom
fix/datanode-internal-appender
Open

Fix name of datanode in-memory internal appender#25521
todvora wants to merge 2 commits intomasterfrom
fix/datanode-internal-appender

Conversation

@todvora
Copy link
Copy Markdown
Contributor

@todvora todvora commented Mar 31, 2026

/nocl internal dev log4j config fix

Could be part of https://github.com/Graylog2/graylog-plugin-enterprise/issues/13625

Description

Corrected internal appender name for datanode logs

How Has This Been Tested?

Manually. Set this JVM option for your datanode and try generating support bundle.

-Dlog4j.configurationFile=file:///home/you/projects/graylog-project-repos/graylog2-server/data-node/config/log4j2.xml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld March 31, 2026 18:15
@todvora
Copy link
Copy Markdown
Contributor Author

todvora commented Mar 31, 2026

@bernd
The build is now failing with

/var/lib/gems/2.7.0/gems/fpm-cookery-0.37.0/lib/fpm/cookery/utils.rb:17:in `safesystem': 'system(["patch -p0 --batch < /vagrant/recipes/graylog-datanode/patches/log4j2.xml.patch"])' failed with error code: 1 (RuntimeError)

I guess we'll need to adapt this patch: https://github.com/Graylog2/fpm-recipes/blob/7.1/recipes/graylog-datanode/patches/log4j2.xml.patch , as the graylog-internal-logs is now called datanode-internal-logs, right?

@bernd
Copy link
Copy Markdown
Member

bernd commented Apr 1, 2026

@bernd The build is now failing with

/var/lib/gems/2.7.0/gems/fpm-cookery-0.37.0/lib/fpm/cookery/utils.rb:17:in `safesystem': 'system(["patch -p0 --batch < /vagrant/recipes/graylog-datanode/patches/log4j2.xml.patch"])' failed with error code: 1 (RuntimeError)

I guess we'll need to adapt this patch: https://github.com/Graylog2/fpm-recipes/blob/7.1/recipes/graylog-datanode/patches/log4j2.xml.patch , as the graylog-internal-logs is now called datanode-internal-logs, right?

Aye. Let me know when you merge this, so I can adjust the patch.

bernd added a commit to Graylog2/fpm-recipes that referenced this pull request Apr 1, 2026
@bernd
Copy link
Copy Markdown
Member

bernd commented Apr 1, 2026

Graylog2/fpm-recipes#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants