fix: Streams Data Lake column not shown on cloud#25513
Open
fix: Streams Data Lake column not shown on cloud#25513
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the missing “Data Lake” column in the Streams overview on cloud by switching the Streams overview table extension mechanism from the dataLake plugin export to a dedicated plugin export key for stream-overview-specific table elements.
Changes:
- Replaced direct
dataLakeplugin export usage and current-user-permission plumbing with a newuseStreamsOverviewExtensions()hook. - Added a new plugin export key (
components.streams.overview.tableElements) and corresponding TypeScript types to allow plugins to contribute Streams overview columns/attributes. - Added a UI test ensuring plugin-provided Streams overview table elements (header + cell rendering) are displayed.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| graylog2-web-interface/src/components/streams/StreamsOverview/StreamsOverview.tsx | Switches Streams overview to use the new extensions hook for plugin-provided columns/attributes. |
| graylog2-web-interface/src/components/streams/StreamsOverview/StreamsOverview.test.tsx | Adds coverage for rendering plugin-contributed Streams overview table elements. |
| graylog2-web-interface/src/components/streams/StreamsOverview/hooks/useStreamsOverviewExtensions.ts | Introduces stream-specific plugin extension merging with generic entity-table extensions. |
| graylog2-web-interface/src/components/streams/StreamsOverview/Constants.ts | Updates default layout/attributes to incorporate extension-provided attributes. |
| graylog2-web-interface/src/components/streams/StreamsOverview/ColumnRenderers.tsx | Updates custom column renderers to consume merged extension renderers (no dataLake export dependency). |
| graylog2-web-interface/src/@types/graylog-web-plugin/index.d.ts | Adds new plugin export typing for Streams overview table elements and removes the legacy Data Lake table element typing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graylog2-web-interface/src/components/streams/StreamsOverview/StreamsOverview.tsx
Show resolved
Hide resolved
...2-web-interface/src/components/streams/StreamsOverview/hooks/useStreamsOverviewExtensions.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Streams Data Lake column not being shown on Cloud by moving the column contribution out of the internal-only
dataLake.getStreamDataLakeTableElementsexport and into the generic top-levelcomponents.streams.overview.tableElementsextension point used by StreamsOverview. Unlike the old path, this export is gated by DATA_LAKE_ENABLED rather than the internal-only Cloud gate DATA_LAKE_INTERNAL_ENABLED, so the column can show on Cloud as well./jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/13724
/nocl
Motivation and Context
fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/13654
Screenshots (if appropriate):
How can this be tested?
check if both internal and external data lakes are preview-able on both cloud and on-prem, via stream page data lake column (preview logs button).
Types of changes
Checklist: