Skip to content

fix: Streams Data Lake column not shown on cloud#25513

Open
gally47 wants to merge 5 commits intomasterfrom
fix-ent-13654
Open

fix: Streams Data Lake column not shown on cloud#25513
gally47 wants to merge 5 commits intomasterfrom
fix-ent-13654

Conversation

@gally47
Copy link
Copy Markdown
Contributor

@gally47 gally47 commented Mar 31, 2026

This PR fixes the Streams Data Lake column not being shown on Cloud by moving the column contribution out of the internal-only dataLake.getStreamDataLakeTableElements export and into the generic top-level components.streams.overview.tableElements extension point used by StreamsOverview. Unlike the old path, this export is gated by DATA_LAKE_ENABLED rather than the internal-only Cloud gate DATA_LAKE_INTERNAL_ENABLED, so the column can show on Cloud as well.

/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/13724

/nocl

Motivation and Context

fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/13654

Screenshots (if appropriate):

Screenshot 2026-04-02 at 11 13 39

How can this be tested?

check if both internal and external data lakes are preview-able on both cloud and on-prem, via stream page data lake column (preview logs button).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the missing “Data Lake” column in the Streams overview on cloud by switching the Streams overview table extension mechanism from the dataLake plugin export to a dedicated plugin export key for stream-overview-specific table elements.

Changes:

  • Replaced direct dataLake plugin export usage and current-user-permission plumbing with a new useStreamsOverviewExtensions() hook.
  • Added a new plugin export key (components.streams.overview.tableElements) and corresponding TypeScript types to allow plugins to contribute Streams overview columns/attributes.
  • Added a UI test ensuring plugin-provided Streams overview table elements (header + cell rendering) are displayed.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
graylog2-web-interface/src/components/streams/StreamsOverview/StreamsOverview.tsx Switches Streams overview to use the new extensions hook for plugin-provided columns/attributes.
graylog2-web-interface/src/components/streams/StreamsOverview/StreamsOverview.test.tsx Adds coverage for rendering plugin-contributed Streams overview table elements.
graylog2-web-interface/src/components/streams/StreamsOverview/hooks/useStreamsOverviewExtensions.ts Introduces stream-specific plugin extension merging with generic entity-table extensions.
graylog2-web-interface/src/components/streams/StreamsOverview/Constants.ts Updates default layout/attributes to incorporate extension-provided attributes.
graylog2-web-interface/src/components/streams/StreamsOverview/ColumnRenderers.tsx Updates custom column renderers to consume merged extension renderers (no dataLake export dependency).
graylog2-web-interface/src/@types/graylog-web-plugin/index.d.ts Adds new plugin export typing for Streams overview table elements and removes the legacy Data Lake table element typing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gally47 gally47 marked this pull request as ready for review April 2, 2026 12:05
@gally47 gally47 requested a review from a team April 2, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants