Fix Grapene CLI compilation

[TrueDoctor]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compilation failures within the graphene-cli component by refining resource management in the export.rs file. The changes ensure that image_texture objects are explicitly dropped after their data has been processed, which resolves lifetime-related errors and allows the application to compile successfully. This adjustment is crucial for maintaining the stability and build integrity of the command-line interface.

Highlights

• Compilation Fix: Resolved compilation errors in graphene-cli by explicitly managing the lifetime of image_texture objects in export functions.
• Resource Management: Introduced std::mem::drop(image_texture) calls to ensure textures are released at the appropriate time, preventing potential borrowing issues.

Changelog

• node-graph/graphene-cli/src/export.rs
  • Explicitly dropped image_texture after converting GPU raster to CPU raster in the export_document function.
  • Explicitly dropped image_texture after converting GPU raster to CPU raster in the export_gif function.

Activity

• No specific activity or comments have been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to fix a compilation issue in graphene-cli by addressing an async lifetime problem. The changes ensure that a texture resource remains alive during an async GPU-to-CPU data conversion by explicitly using the texture handle after the .await point. The fix is applied consistently in two functions, export_document and export_gif. My feedback includes suggestions to improve the clarity of the comments explaining this pattern, which will enhance code maintainability.

[cubic-dev-ai]

No issues found across 1 file

[cubic-dev-ai]

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/graph-craft/Cargo.toml">

<violation number="1" location="node-graph/graph-craft/Cargo.toml:9">
P2: `loading` is already enabled by `graphene-cli`, so adding it to `graph-craft`'s default features won't change the CLI build and instead enables that feature for every default consumer.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: loading is already enabled by graphene-cli, so adding it to graph-craft's default features won't change the CLI build and instead enables that feature for every default consumer.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At node-graph/graph-craft/Cargo.toml, line 9:

<comment>`loading` is already enabled by `graphene-cli`, so adding it to `graph-craft`'s default features won't change the CLI build and instead enables that feature for every default consumer.</comment>

<file context>
@@ -6,7 +6,7 @@ license = "MIT OR Apache-2.0"
 
 [features]
-default = ["dealloc_nodes", "wgpu"]
+default = ["dealloc_nodes", "wgpu", "loading"]
 dealloc_nodes = ["core-types/dealloc_nodes"]
 wgpu = ["wgpu-executor"]
</file context>

Suggested change

	default = ["dealloc_nodes", "wgpu", "loading"]
	default = ["dealloc_nodes", "wgpu"]