Skip to content

fix: prevent geometry shift in Auto-Tangents when spread is 0 #3890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chetansahney wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent geometry shift in Auto-Tangents when spread is 0 #3890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions node-graph/nodes/vector/src/vector_nodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,13 @@ async fn auto_tangents(

for i in 0..manipulators_list.len() {
let curr = &manipulators_list[i];

// Changes to the original logic:
if preserve_existing && spread == 0.0
{
new_manipulators_list.push(*curr);
continue;
}
Comment on lines +906 to +912
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The added logic is correct. However, it can be formatted more idiomatically to improve readability. The temporary comment and extra blank line can be removed, and the if statement can be formatted using standard Rust style (opening brace on the same line).

 					if preserve_existing && spread == 0.0 {
 						new_manipulators_list.push(*curr);
 						continue;
 					}


if preserve_existing {
// Check if this point has handles that are meaningfully different from the anchor
Expand Down