-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix regression breaking Into/Convert node type coercion #3681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance Benchmark Results
|
| } | ||
|
|
||
| pub fn to_cow_string(&self) -> Cow<'static, str> { | ||
| pub fn identifier_name(&self) -> String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for the changed return type here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a change, one unused function is deleted and another new function is added in the same location.
Fixes a regression from #3662. Closes #3677.
This also refactors some code messiness around how we did
Displayvs.Debugprinting of type representations.