Skip to content

Conversation

@Keavon
Copy link
Member

@Keavon Keavon commented Jan 25, 2026

Fixes a regression from #3662. Closes #3677.

This also refactors some code messiness around how we did Display vs. Debug printing of type representations.

@github-actions
Copy link

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 27,779,447 (master) → 27,782,110 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.09%
D1mr                     369,862|    369,367          -0.13%
D1mw                     108,420|    108,480          +0.06%
DLmr                      32,337|     32,334          -0.01%
DLmw                      49,281|     49,276          -0.01%
Dr                     6,879,590|  6,879,852          +0.00%
Dw                     4,751,178|  4,751,151          -0.00%
EstimatedCycles       44,000,729| 43,977,653          -0.05%
I1MissRate                     0|          0         -12.01%
I1mr                      50,934|     44,823         -12.00%
ILmr                         837|        852          +1.79%
Ir                    27,779,447| 27,782,110          +0.01%
L1HitRate                     99|         99          +0.02%
L1hits                38,880,999| 38,890,443          +0.02%
LLHitRate                      1|          1          -1.47%
LLMissRate                     0|          0          +0.00%
LLdMissRate                    1|          1          -0.01%
LLhits                   446,761|    440,208          -1.47%
LLiMissRate                    0|          0          +1.78%
RamHitRate                     0|          0          +0.00%
RamHits                   82,455|     82,462          +0.01%
TotalRW               39,410,215| 39,413,113          +0.01%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 13,975,010 (master) → 13,973,016 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.00%
D1mr                     175,720|    175,723          +0.00%
D1mw                      55,643|     55,650          +0.01%
DLmr                         917|        921          +0.44%
DLmw                      16,289|     16,254          -0.21%
Dr                     3,470,779|  3,470,657          -0.00%
Dw                     2,386,244|  2,386,350          +0.00%
EstimatedCycles       21,395,091| 21,381,335          -0.06%
I1MissRate                     0|          0         -11.11%
I1mr                      25,204|     22,400         -11.13%
ILmr                         687|        699          +1.75%
Ir                    13,975,010| 13,973,016          -0.01%
L1HitRate                     99|         99          +0.01%
L1hits                19,575,466| 19,576,250          +0.00%
LLHitRate                      1|          1          -1.15%
LLMissRate                     0|          0          -0.10%
LLdMissRate                    0|          0          -0.18%
LLhits                   238,674|    235,899          -1.16%
LLiMissRate                    0|          0          +1.76%
RamHitRate                     0|          0          -0.10%
RamHits                   17,893|     17,874          -0.11%
TotalRW               19,832,033| 19,830,023          -0.01%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 3,110,267 (master) → 3,109,928 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.03%
D1mr                      37,744|     37,739          -0.01%
D1mw                      11,268|     11,286          +0.16%
DLmr                          15|         18         +20.00%
DLmw                       2,493|      2,495          +0.08%
Dr                       759,518|    759,483          -0.00%
Dw                       524,102|    524,101          -0.00%
EstimatedCycles        4,706,855|  4,704,744          -0.04%
I1MissRate                     0|          0         -10.68%
I1mr                       5,305|      4,738         -10.69%
ILmr                         682|        693          +1.61%
Ir                     3,110,267|  3,109,928          -0.01%
L1HitRate                     99|         99          +0.01%
L1hits                 4,339,570|  4,339,749          +0.00%
LLHitRate                      1|          1          -1.11%
LLMissRate                     0|          0          +0.51%
LLdMissRate                    0|          0          +0.20%
LLhits                    51,127|     50,557          -1.11%
LLiMissRate                    0|          0          +1.62%
RamHitRate                     0|          0          +0.51%
RamHits                    3,190|      3,206          +0.50%
TotalRW                4,393,887|  4,393,512          -0.01%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 13,759,797 (master) → 13,757,584 (HEAD) : $$\color{lime}-0.02\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.06%
D1mr                     176,181|    176,073          -0.06%
D1mw                      51,770|     51,721          -0.09%
DLmr                          63|         64          +1.59%
DLmw                      14,098|     14,088          -0.07%
Dr                     3,370,950|  3,370,695          -0.01%
Dw                     2,344,459|  2,344,447          -0.00%
EstimatedCycles       20,912,618| 20,904,042          -0.04%
I1MissRate                     0|          0          -7.33%
I1mr                      19,217|     17,805          -7.35%
ILmr                         797|        812          +1.88%
Ir                    13,759,797| 13,757,584          -0.02%
L1HitRate                     99|         99          +0.01%
L1hits                19,228,038| 19,227,127          -0.00%
LLHitRate                      1|          1          -0.67%
LLMissRate                     0|          0          +0.05%
LLdMissRate                    0|          0          -0.06%
LLhits                   232,210|    230,635          -0.68%
LLiMissRate                    0|          0          +1.90%
RamHitRate                     0|          0          +0.05%
RamHits                   14,958|     14,964          +0.04%
TotalRW               19,475,206| 19,472,726          -0.01%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 32,415,511 (master) → 32,416,204 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          -0.08%
D1mr                     428,888|    428,398          -0.11%
D1mw                     124,659|    124,705          +0.04%
DLmr                      43,671|     43,675          +0.01%
DLmw                      58,890|     58,865          -0.04%
Dr                     7,993,264|  7,993,319          +0.00%
Dw                     5,523,128|  5,523,120          -0.00%
EstimatedCycles       51,475,317| 51,446,839          -0.06%
I1MissRate                     0|          0         -12.03%
I1mr                      56,829|     49,991         -12.03%
ILmr                         836|        854          +2.15%
Ir                    32,415,511| 32,416,204          +0.00%
L1HitRate                     99|         99          +0.02%
L1hits                45,321,527| 45,329,549          +0.02%
LLHitRate                      1|          1          -1.44%
LLMissRate                     0|          0          -0.00%
LLdMissRate                    1|          1          -0.02%
LLhits                   506,979|    499,700          -1.44%
LLiMissRate                    0|          0          +2.15%
RamHitRate                     0|          0          -0.00%
RamHits                  103,397|    103,394          -0.00%
TotalRW               45,931,903| 45,932,643          +0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 21,417,346 (master) → 21,415,554 (HEAD) : $$\color{lime}-0.01\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     4|          4          +0.04%
D1mr                     271,437|    271,460          +0.01%
D1mw                      79,331|     79,440          +0.14%
DLmr                      15,576|     15,652          +0.49%
DLmw                      29,460|     29,477          +0.06%
Dr                     5,299,708|  5,299,635          -0.00%
Dw                     3,652,776|  3,652,857          +0.00%
EstimatedCycles       33,300,756| 33,283,808          -0.05%
I1MissRate                     0|          0         -12.38%
I1mr                      38,321|     33,573         -12.39%
ILmr                         783|        800          +2.17%
Ir                    21,417,346| 21,415,554          -0.01%
L1HitRate                     99|         99          +0.02%
L1hits                29,980,741| 29,983,573          +0.01%
LLHitRate                      1|          1          -1.37%
LLMissRate                     0|          0          +0.25%
LLdMissRate                    1|          1          +0.21%
LLhits                   343,270|    338,544          -1.38%
LLiMissRate                    0|          0          +2.18%
RamHitRate                     0|          0          +0.25%
RamHits                   45,819|     45,929          +0.24%
TotalRW               30,369,830| 30,368,046          -0.01%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 46,744,730 (master) → 51,050,293 (HEAD) : $$\color{red}+9.21\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -1.99%
D1mr                     516,412|    556,495          +7.76%
D1mw                     116,273|    129,878         +11.70%
DLmr                       3,112|      3,900         +25.32%
DLmw                      12,776|     20,009         +56.61%
Dr                    11,758,170| 12,986,484         +10.45%
Dw                     7,967,905|  8,847,255         +11.04%
EstimatedCycles       69,592,573| 76,455,318          +9.86%
I1MissRate                     0|          0         -14.53%
I1mr                      27,217|     25,406          -6.65%
ILmr                         184|        230         +25.00%
Ir                    46,744,730| 51,050,293          +9.21%
L1HitRate                     99|         99          +0.02%
L1hits                65,810,903| 72,172,253          +9.67%
LLHitRate                      1|          1          -2.59%
LLMissRate                     0|          0         +36.98%
LLdMissRate                    0|          0         +35.96%
LLhits                   643,830|    687,640          +6.80%
LLiMissRate                    0|          0         +14.46%
RamHitRate                     0|          0         +36.98%
RamHits                   16,072|     24,139         +50.19%
TotalRW               66,470,805| 72,884,032          +9.65%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 24,081,861 (master) → 25,206,289 (HEAD) : $$\color{red}+4.67\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -1.44%
D1mr                     255,229|    267,474          +4.80%
D1mw                      57,456|     62,727          +9.17%
DLmr                         858|        865          +0.82%
DLmw                       5,653|      4,094         -27.58%
Dr                     6,043,253|  6,444,331          +6.64%
Dw                     4,100,271|  4,424,246          +7.90%
EstimatedCycles       35,742,773| 37,606,480          +5.21%
I1MissRate                     0|          0         -17.95%
I1mr                      16,592|     14,250         -14.12%
ILmr                         165|        168          +1.82%
Ir                    24,081,861| 25,206,289          +4.67%
L1HitRate                     99|         99          +0.01%
L1hits                33,896,108| 35,730,415          +5.41%
LLHitRate                      1|          1          -0.21%
LLMissRate                     0|          0         -27.14%
LLdMissRate                    0|          0         -28.92%
LLhits                   322,601|    339,324          +5.18%
LLiMissRate                    0|          0          -2.72%
RamHitRate                     0|          0         -27.14%
RamHits                    6,676|      5,127         -23.20%
TotalRW               34,225,385| 36,074,866          +5.40%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 5,827,523 (master) → 6,303,021 (HEAD) : $$\color{red}+8.16\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -1.18%
D1mr                      59,202|     63,431          +7.14%
D1mw                      14,157|     16,149         +14.07%
DLmr                           2|          1         -50.00%
DLmw                         272|        414         +52.21%
Dr                     1,462,064|  1,597,451          +9.26%
Dw                       991,171|  1,095,662         +10.54%
EstimatedCycles        8,608,550|  9,350,658          +8.62%
I1MissRate                     0|          0         -17.59%
I1mr                       5,274|      4,701         -10.86%
ILmr                         168|        165          -1.79%
Ir                     5,827,523|  6,303,021          +8.16%
L1HitRate                     99|         99          +0.01%
L1hits                 8,202,125|  8,911,853          +8.65%
LLHitRate                      1|          1          -1.47%
LLMissRate                     0|          0         +20.79%
LLdMissRate                    0|          0         +37.97%
LLhits                    78,191|     83,701          +7.05%
LLiMissRate                    0|          0          -9.19%
RamHitRate                     0|          0         +20.79%
RamHits                      442|        580         +31.22%
TotalRW                8,280,758|  8,996,134          +8.64%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 27,856,365 (master) → 27,107,307 (HEAD) : $$\color{lime}-2.69\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +1.74%
D1mr                     276,576|    278,246          +0.60%
D1mw                      68,790|     70,090          +1.89%
DLmr                         159|        155          -2.52%
DLmw                       3,666|      3,867          +5.48%
Dr                     6,974,679|  6,891,468          -1.19%
Dw                     4,817,750|  4,798,588          -0.40%
EstimatedCycles       41,205,212| 40,362,065          -2.05%
I1MissRate                     0|          0         -14.79%
I1mr                      13,866|     11,497         -17.08%
ILmr                         158|        157          -0.63%
Ir                    27,856,365| 27,107,307          -2.69%
L1HitRate                     99|         99          -0.02%
L1hits                39,289,562| 38,437,530          -2.17%
LLHitRate                      1|          1          +2.31%
LLMissRate                     0|          0          +7.22%
LLdMissRate                    0|          0          +6.07%
LLhits                   355,249|    355,654          +0.11%
LLiMissRate                    0|          0          +2.11%
RamHitRate                     0|          0          +7.22%
RamHits                    3,983|      4,179          +4.92%
TotalRW               39,648,794| 38,797,363          -2.15%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 63,979,352 (master) → 60,196,419 (HEAD) : $$\color{lime}-5.91\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          +2.39%
D1mr                     677,741|    655,546          -3.27%
D1mw                     158,781|    151,520          -4.57%
DLmr                      11,268|      9,967         -11.55%
DLmw                      27,792|     30,534          +9.87%
Dr                    16,219,608| 15,287,863          -5.74%
Dw                    11,054,121| 10,410,999          -5.82%
EstimatedCycles       95,909,727| 90,457,505          -5.68%
I1MissRate                     0|          0          -9.84%
I1mr                      32,087|     27,220         -15.17%
ILmr                         347|        335          -3.46%
Ir                    63,979,352| 60,196,419          -5.91%
L1HitRate                     99|         99          -0.02%
L1hits                90,384,472| 85,060,995          -5.89%
LLHitRate                      1|          1          +1.66%
LLMissRate                     0|          0         +10.09%
LLdMissRate                    0|          0         +10.04%
LLhits                   829,202|    793,450          -4.31%
LLiMissRate                    0|          0          +2.61%
RamHitRate                     0|          0         +10.09%
RamHits                   39,407|     40,836          +3.63%
TotalRW               91,253,081| 85,895,281          -5.87%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 35,986,031 (master) → 37,160,242 (HEAD) : $$\color{red}+3.26\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.62%
D1mr                     388,207|    402,876          +3.78%
D1mw                      87,205|     92,362          +5.91%
DLmr                       2,346|      2,286          -2.56%
DLmw                       5,551|     11,924        +114.81%
Dr                     9,013,879|  9,423,446          +4.54%
Dw                     6,078,908|  6,396,707          +5.23%
EstimatedCycles       53,314,318| 55,473,535          +4.05%
I1MissRate                     0|          0         -14.96%
I1mr                      22,983|     20,182         -12.19%
ILmr                         167|        172          +2.99%
Ir                    35,986,031| 37,160,242          +3.26%
L1HitRate                     99|         99          +0.00%
L1hits                50,580,423| 52,464,975          +3.73%
LLHitRate                      1|          1          -1.48%
LLMissRate                     0|          0         +71.95%
LLdMissRate                    0|          0         +71.67%
LLhits                   490,331|    501,038          +2.18%
LLiMissRate                    0|          0          -0.26%
RamHitRate                     0|          0         +71.95%
RamHits                    8,064|     14,382         +78.35%
TotalRW               51,078,818| 52,980,395          +3.72%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 22,847,672 (master) → 23,472,177 (HEAD) : $$\color{red}+2.73\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.46%
D1mr                     277,880|    290,703          +4.61%
D1mw                      59,532|     59,698          +0.28%
DLmr                       8,122|      9,230         +13.64%
DLmw                       9,456|      9,220          -2.50%
Dr                     5,892,023|  6,135,901          +4.14%
Dw                     3,980,123|  4,163,648          +4.61%
EstimatedCycles       35,295,672| 36,426,964          +3.21%
I1MissRate                     1|          1          -2.68%
I1mr                     133,564|    133,536          -0.02%
ILmr                       5,487|      5,533          +0.84%
Ir                    22,847,672| 23,472,177          +2.73%
L1HitRate                     99|         99          +0.01%
L1hits                32,248,842| 33,287,789          +3.22%
LLHitRate                      1|          1          -0.51%
LLMissRate                     0|          0          +0.74%
LLdMissRate                    0|          0          +0.61%
LLhits                   447,911|    459,954          +2.69%
LLiMissRate                    0|          0          -1.84%
RamHitRate                     0|          0          +0.74%
RamHits                   23,065|     23,983          +3.98%
TotalRW               32,719,818| 33,771,726          +3.21%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 78,996,090 (master) → 79,068,093 (HEAD) : $$\color{red}+0.09\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          -0.16%
D1mr                     405,658|    405,677          +0.00%
D1mw                     194,172|    192,942          -0.63%
DLmr                       3,582|      3,654          +2.01%
DLmw                      25,605|     26,166          +2.19%
Dr                    18,741,272| 18,742,894          +0.01%
Dw                    12,488,283| 12,473,142          -0.12%
EstimatedCycles      114,479,851|114,540,047          +0.05%
I1MissRate                     0|          0          -2.03%
I1mr                     187,384|    183,743          -1.94%
ILmr                       7,658|      7,729          +0.93%
Ir                    78,996,090| 79,068,093          +0.09%
L1HitRate                     99|         99          +0.00%
L1hits               109,438,431|109,501,767          +0.06%
LLHitRate                      1|          1          -0.79%
LLMissRate                     0|          0          +1.86%
LLdMissRate                    0|          0          +2.21%
LLhits                   750,369|    744,813          -0.74%
LLiMissRate                    0|          0          +0.84%
RamHitRate                     0|          0          +1.86%
RamHits                   36,845|     37,549          +1.91%
TotalRW              110,225,645|110,284,129          +0.05%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 10,742,124 (master) → 10,942,388 (HEAD) : $$\color{red}+1.86\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          +2.93%
D1mr                      60,366|     64,428          +6.73%
D1mw                      23,332|     23,103          -0.98%
DLmr                         448|        454          +1.34%
DLmw                       1,272|        841         -33.88%
Dr                     2,643,195|  2,690,435          +1.79%
Dw                     1,904,827|  1,930,365          +1.34%
EstimatedCycles       16,002,224| 16,276,126          +1.71%
I1MissRate                     0|          0          -3.42%
I1mr                      46,464|     45,711          -1.62%
ILmr                       4,661|      4,704          +0.92%
Ir                    10,742,124| 10,942,388          +1.86%
L1HitRate                     99|         99          -0.00%
L1hits                15,159,984| 15,429,946          +1.78%
LLHitRate                      1|          1          +0.99%
LLMissRate                     0|          0          -7.64%
LLdMissRate                    0|          0         -25.90%
LLhits                   123,781|    127,243          +2.80%
LLiMissRate                    0|          0          -0.92%
RamHitRate                     0|          0          -7.64%
RamHits                    6,381|      5,999          -5.99%
TotalRW               15,290,146| 15,563,188          +1.79%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 24,747,792 (master) → 24,798,218 (HEAD) : $$\color{red}+0.20\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     2|          2          -1.92%
D1mr                     157,116|    157,621          +0.32%
D1mw                      60,546|     61,657          +1.83%
DLmr                       2,367|      2,406          +1.65%
DLmw                       2,816|      3,306         +17.40%
Dr                     5,754,788|  5,878,192          +2.14%
Dw                     3,702,309|  3,835,322          +3.59%
EstimatedCycles       35,629,763| 35,951,142          +0.90%
I1MissRate                     0|          0          -3.38%
I1mr                      70,824|     68,567          -3.19%
ILmr                       3,848|      3,889          +1.07%
Ir                    24,747,792| 24,798,218          +0.20%
L1HitRate                     99|         99          +0.01%
L1hits                33,916,403| 34,223,887          +0.91%
LLHitRate                      1|          1          -1.32%
LLMissRate                     0|          0          +5.37%
LLdMissRate                    0|          0          +7.30%
LLhits                   279,455|    278,244          -0.43%
LLiMissRate                    0|          0          +0.86%
RamHitRate                     0|          0          +5.37%
RamHits                    9,031|      9,601          +6.31%
TotalRW               34,204,889| 34,511,732          +0.90%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,804,872,136 (master) → 1,804,513,342 (HEAD) : $$\color{lime}-0.02\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     0|          0          -1.75%
D1mr                   1,921,247|  1,878,414          -2.23%
D1mw                     875,834|    868,223          -0.87%
DLmr                     455,508|    457,438          +0.42%
DLmw                     525,349|    530,449          +0.97%
Dr                   436,414,606|436,202,406          -0.05%
Dw                   282,721,570|282,534,151          -0.07%
EstimatedCycles      2,569,937,180|2,568,776,671          -0.05%
I1MissRate                     0|          0          -8.01%
I1mr                   1,287,496|  1,184,196          -8.02%
ILmr                       5,495|      5,561          +1.20%
Ir                   1,804,872,136|1,804,513,342          -0.02%
L1HitRate                    100|        100          +0.01%
L1hits               2,519,923,735|2,519,319,066          -0.02%
LLHitRate                      0|          0          -5.16%
LLMissRate                     0|          0          +0.75%
LLdMissRate                    0|          0          +0.77%
LLhits                 3,098,225|  2,937,385          -5.19%
LLiMissRate                    0|          0          +1.22%
RamHitRate                     0|          0          +0.75%
RamHits                  986,352|    993,448          +0.72%
TotalRW              2,524,008,312|2,523,249,899          -0.03%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 20,981,780 (master) → 21,069,555 (HEAD) : $$\color{red}+0.42\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     3|          3          -0.34%
D1mr                     222,840|    222,972          +0.06%
D1mw                      53,863|     52,622          -2.30%
DLmr                       5,171|      5,171          +0.00%
DLmw                       6,402|      5,463         -14.67%
Dr                     5,279,072|  5,284,266          +0.10%
Dw                     3,569,567|  3,559,350          -0.29%
EstimatedCycles       31,823,575| 31,869,405          +0.14%
I1MissRate                     1|          1          -1.57%
I1mr                     107,511|    106,267          -1.16%
ILmr                       3,637|      3,659          +0.60%
Ir                    20,981,780| 21,069,555          +0.42%
L1HitRate                     99|         99          +0.01%
L1hits                29,446,205| 29,531,310          +0.29%
LLHitRate                      1|          1          -0.66%
LLMissRate                     0|          0          -6.29%
LLdMissRate                    0|          0          -8.06%
LLhits                   369,004|    367,568          -0.39%
LLiMissRate                    0|          0          +0.19%
RamHitRate                     0|          0          -6.29%
RamHits                   15,210|     14,293          -6.03%
TotalRW               29,830,419| 29,913,171          +0.28%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 7,825,460 (master) → 8,235,691 (HEAD) : $$\color{red}+5.24\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     6|          5          -1.47%
D1mr                     197,124|    210,224          +6.65%
D1mw                       6,357|      7,520         +18.29%
DLmr                       1,168|      2,142         +83.39%
DLmw                         118|        216         +83.05%
Dr                     2,321,807|  2,500,221          +7.68%
Dw                     1,344,804|  1,481,857         +10.19%
EstimatedCycles       12,352,473| 13,167,653          +6.60%
I1MissRate                     0|          0          -2.97%
I1mr                         707|        722          +2.12%
ILmr                         169|        176          +4.14%
Ir                     7,825,460|  8,235,691          +5.24%
L1HitRate                     98|         98          -0.01%
L1hits                11,287,883| 11,999,303          +6.30%
LLHitRate                      2|          2          +0.18%
LLMissRate                     0|          0         +63.81%
LLdMissRate                    0|          0         +68.83%
LLhits                   202,733|    215,932          +6.51%
LLiMissRate                    0|          0          -1.05%
RamHitRate                     0|          0         +63.81%
RamHits                    1,455|      2,534         +74.16%
TotalRW               11,492,071| 12,217,769          +6.31%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 5,942,154 (master) → 6,020,102 (HEAD) : $$\color{red}+1.31\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          +0.39%
D1mr                     130,323|    132,406          +1.60%
D1mw                       7,153|      7,195          +0.59%
DLmr                         177|        235         +32.77%
DLmw                         134|        138          +2.99%
Dr                     1,849,456|  1,871,427          +1.19%
Dw                     1,109,410|  1,121,423          +1.08%
EstimatedCycles        9,467,910|  9,590,652          +1.30%
I1MissRate                     0|          0          +0.78%
I1mr                         714|        729          +2.10%
ILmr                         160|        173          +8.13%
Ir                     5,942,154|  6,020,102          +1.31%
L1HitRate                     98|         98          -0.00%
L1hits                 8,762,830|  8,872,622          +1.25%
LLHitRate                      2|          2          +0.24%
LLMissRate                     0|          0         +14.48%
LLdMissRate                    0|          0         +18.57%
LLhits                   137,719|    139,784          +1.50%
LLiMissRate                    0|          0          +6.73%
RamHitRate                     0|          0         +14.48%
RamHits                      471|        546         +15.92%
TotalRW                8,901,020|  9,012,952          +1.26%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(parametric-dunescape)
Instructions: 3,741,794 (master) → 3,720,073 (HEAD) : $$\color{lime}-0.58\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          +0.06%
D1mr                      93,476|     93,111          -0.39%
D1mw                       7,695|      7,699          +0.05%
DLmr                          26|         28          +7.69%
DLmw                          31|         33          +6.45%
Dr                     1,264,517|  1,258,974          -0.44%
Dw                       828,556|    825,371          -0.38%
EstimatedCycles        6,248,093|  6,216,380          -0.51%
I1MissRate                     0|          0          +0.58%
I1mr                         688|        688          +0.00%
ILmr                         136|        138          +1.47%
Ir                     3,741,794|  3,720,073          -0.58%
L1HitRate                     98|         98          -0.00%
L1hits                 5,733,008|  5,702,920          -0.52%
LLHitRate                      2|          2          +0.16%
LLMissRate                     0|          0          +3.65%
LLdMissRate                    0|          0          +7.47%
LLhits                   101,666|    101,299          -0.36%
LLiMissRate                    0|          0          +2.06%
RamHitRate                     0|          0          +3.65%
RamHits                      193|        199          +3.11%
TotalRW                5,834,867|  5,804,418          -0.52%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(red-dress)
Instructions: 35,555,747 (master) → 35,396,285 (HEAD) : $$\color{lime}-0.45\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          -0.45%
D1mr                     686,295|    678,859          -1.08%
D1mw                     101,189|    100,952          -0.23%
DLmr                     303,359|    298,172          -1.71%
DLmw                      60,281|     50,695         -15.90%
Dr                    10,157,230| 10,103,529          -0.53%
Dw                     5,521,949|  5,492,628          -0.53%
EstimatedCycles       65,319,014| 64,602,988          -1.10%
I1MissRate                     0|          0          +1.77%
I1mr                         763|        773          +1.31%
ILmr                         730|        740          +1.37%
Ir                    35,555,747| 35,396,285          -0.45%
L1HitRate                     98|         98          +0.01%
L1hits                50,446,679| 50,211,858          -0.47%
LLHitRate                      1|          1          +2.16%
LLMissRate                     1|          1          -3.60%
LLdMissRate                    2|          2          -3.55%
LLhits                   423,877|    430,977          +1.68%
LLiMissRate                    0|          0          +1.83%
RamHitRate                     1|          1          -3.60%
RamHits                  364,370|    349,607          -4.05%
TotalRW               51,234,926| 50,992,442          -0.47%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(valley-of-spires)
Instructions: 6,284,350 (master) → 6,469,410 (HEAD) : $$\color{red}+2.94\%$$

Detailed metrics
Baselines:                master|       HEAD
D1MissRate                     5|          5          -4.07%
D1mr                     156,052|    158,895          +1.82%
D1mw                       6,423|      7,680         +19.57%
DLmr                         111|        102          -8.11%
DLmw                         226|        124         -45.13%
Dr                     1,871,441|  1,979,985          +5.80%
Dw                     1,091,531|  1,186,475          +8.70%
EstimatedCycles        9,914,618| 10,316,376          +4.05%
I1MissRate                     0|          0          -0.04%
I1mr                         689|        709          +2.90%
ILmr                         151|        153          +1.32%
Ir                     6,284,350|  6,469,410          +2.94%
L1HitRate                     98|         98          +0.03%
L1hits                 9,084,158|  9,468,586          +4.23%
LLHitRate                      2|          2          -1.54%
LLMissRate                     0|          0         -25.47%
LLdMissRate                    0|          0         -37.25%
LLhits                   162,676|    166,905          +2.60%
LLiMissRate                    0|          0          -1.57%
RamHitRate                     0|          0         -25.47%
RamHits                      488|        379         -22.34%
TotalRW                9,247,322|  9,635,870          +4.20%

}

pub fn to_cow_string(&self) -> Cow<'static, str> {
pub fn identifier_name(&self) -> String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for the changed return type here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a change, one unused function is deleted and another new function is added in the same location.

@Keavon Keavon merged commit 568831b into master Jan 26, 2026
3 of 4 checks passed
@Keavon Keavon deleted the node-printing-fixes branch January 26, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert node no longer supports strings

3 participants