Skip to content

Fix Enter fails to confirm in the New Document dialog after editing values #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abdoshbr3322 wants to merge 6 commits into from
Closed

Fix Enter fails to confirm in the New Document dialog after editing values #3615

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9481d8f
Fix enter button not working while focusing on input fields in the ne…
abdoshbr3322 Jan 8, 2026
9bbf242
select the pop element using it's data attribute
abdoshbr3322 Jan 9, 2026
60b2521
Update frontend/src/components/floating-menus/Dialog.svelte
Keavon Jan 12, 2026
130c295
Use meaningful variable names
abdoshbr3322 Jan 12, 2026
ab0a7d1
small fix in variable names
abdoshbr3322 Jan 12, 2026
07d6a0d
remove redundant extra selector set on failure
abdoshbr3322 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions frontend/src/components/floating-menus/Dialog.svelte
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@Ayush2k02 Ayush2k02 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look closely at these files

MenuList.svelte:68-75
ColorPicker.svelte:408-410
ScrollbarInput.svelte:201-207

we always have a onDestroy after an onMount , not related to the changes from this PR , but would probably be a good idea to cleanup this stale event handler

Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
// Focus the button which is marked as emphasized, or otherwise the first button, in the popup
const emphasizedOrFirstButton = (self?.div?.()?.querySelector("[data-emphasized]") || self?.div?.()?.querySelector("[data-text-button]") || undefined) as HTMLButtonElement | undefined;
emphasizedOrFirstButton?.focus();

// Add an event to handle enter press on all focusable fields(inputs) inside the popup
const floatingMenu = (self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLDivElement | undefined;
floatingMenu?.addEventListener("keydown", function (event) {
if (event.key == "Enter") {
Copy link
Copy Markdown
Contributor

@Ayush2k02 Ayush2k02 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT : maybe use === , instead of == , for string comparisons

emphasizedOrFirstButton?.click();
}
});
});
</script>

Expand Down
Loading