explicitly zero out rnd in random_state_init/random_state_init_from_random_state after key/iv setup#367
Open
rdevshp wants to merge 1 commit into
Open
explicitly zero out rnd in random_state_init/random_state_init_from_random_state after key/iv setup#367rdevshp wants to merge 1 commit into
rdevshp wants to merge 1 commit into
Conversation
…andom_state after key/iv setup
Member
|
We could do this but it makes very little difference in practice. This would have essentially 0 performance cost but there are other places this could be done which would have a significant performance cost such as when giving out the generated random data from the cache prior to filling it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.