Skip to content

Test relocation of nested class signatures #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 1 commit into from
Jul 15, 2026
+17 −0
Merged

Test relocation of nested class signatures #2108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/BytecodeRemappingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,17 @@ class BytecodeRemappingTest {
assertThat(checkNotNull(method.signature)).contains("L$relocatedFixtureBase;")
}

@Test
fun nestedClassSignatureIsRelocated() {
val result = fixtureSubjectDetails.remapClass(relocators)

val method = result.classInfo().methodData.first { it.name == "methodWithNestedGeneric" }
assertThat(checkNotNull(method.signature))
.isEqualTo(
$$"(Lcom/example/relocated/BytecodeRemappingTest$FixtureGenericOuter<Lcom/example/relocated/BytecodeRemappingTest$FixtureBase;>.FixtureInner;)V"
)
Comment thread
Goooler marked this conversation as resolved.
}

@Test
fun localVariableIsRelocated() {
val result = fixtureSubjectDetails.remapClass(relocators)
Expand Down Expand Up @@ -255,6 +266,10 @@ class BytecodeRemappingTest {

open class FixtureBase

class FixtureGenericOuter<T> {
inner class FixtureInner
}

@Suppress("unused") // Used by parsing bytecode.
@FixtureAnnotation
class FixtureSubject : FixtureBase(), FixtureInterface {
Expand Down Expand Up @@ -292,6 +307,8 @@ class BytecodeRemappingTest {
}

fun methodWithGeneric(list: List<FixtureBase>): FixtureBase = list[0]

fun methodWithNestedGeneric(arg: FixtureGenericOuter<FixtureBase>.FixtureInner) = Unit
}
}

Expand Down