Skip to content

Fix DuplicatesStrategyCheckerTest resource loading on Windows #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 1 commit into from
Jul 6, 2026
+3 −4
Merged

Fix DuplicatesStrategyCheckerTest resource loading on Windows #2085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...tlin/com/github/jengelman/gradle/plugins/shadow/internal/DuplicatesStrategyCheckerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import kotlin.io.path.createTempFile
import kotlin.io.path.exists
import kotlin.io.path.extension
import kotlin.io.path.isRegularFile
import kotlin.io.path.pathString
import kotlin.io.path.toPath
import kotlin.io.path.walk
import kotlin.reflect.full.isSubclassOf
Expand Down Expand Up @@ -48,7 +47,7 @@ class DuplicatesStrategyCheckerTest {
private fun getTransformerClasses(): List<Class<out ResourceTransformer>> {
val packageName = "com.github.jengelman.gradle.plugins.shadow.transformers"
val parentClass = ResourceTransformer::class
val packagePath = packageName.replace('.', File.separatorChar)
val packagePath = packageName.replace('.', '/')
val classLoader =
Thread.currentThread().contextClassLoader ?: ResourceTransformer::class.java.classLoader
val resources = classLoader.getResources(packagePath)
Expand All @@ -72,8 +71,8 @@ private fun getTransformerClasses(): List<Class<out ResourceTransformer>> {
.walk()
.filter { it.isRegularFile() && it.extension == "class" }
.forEach { file ->
val relativePath = file.pathString.substringAfter(packagePath).removeSuffix(".class")
val className = packageName + relativePath.replace(File.separatorChar, '.')
val relativePath = directory.relativize(file).toString().removeSuffix(".class")
val className = packageName + "." + relativePath.replace(File.separatorChar, '.')
block(className)
}
}
Expand Down