Test that string consts are relocated by default#1405
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new functional test to verify that string constants are relocated by default when building a shadow JAR.
- Introduces a new test function (relocateStringConstantsByDefault) that writes a simple Java class printing a string constant.
- Configures the shadow JAR task in the build script to relocate package names and asserts the relocated string is present in the JAR's output.
Comments suppressed due to low confidence (1)
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/RelocationTest.kt:612
- [nitpick] Consider asserting the process exit code in addition to verifying the output to fully validate that the relocated JAR executes successfully.
val result = runProcess("java", "-jar", pathString)
Goooler
commented
Apr 17, 2025
Comment on lines
594
to
597
| System.out.println(getValue() + junit); | ||
| System.out.println("junit.framework.Test"); | ||
| } | ||
| // Use this method to force the compiler to not inline the string literal. | ||
| private static String getValue() { return "the value is "; } |
Member
Author
There was a problem hiding this comment.
getValue() + junit has still been inlined, we should use a const directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1401.