Skip to content

fix: Pin csharp-ls to exact NuGet version in Docker builds #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GordonBeeming merged 1 commit into from
Mar 24, 2026
Merged

fix: Pin csharp-ls to exact NuGet version in Docker builds #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ jobs:
repo_name: ${{ steps.repo.outputs.name }}
copilot_version: ${{ steps.versions.outputs.copilot_version }}
playwright_version: ${{ steps.versions.outputs.playwright_version }}
csharp_ls_version: ${{ steps.versions.outputs.csharp_ls_version }}
dotnet_8_version: ${{ steps.versions.outputs.dotnet_8_version }}
dotnet_9_version: ${{ steps.versions.outputs.dotnet_9_version }}
dotnet_10_version: ${{ steps.versions.outputs.dotnet_10_version }}
Expand All @@ -369,6 +370,9 @@ jobs:
DOTNET_10_VERSION=$(curl -s https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/10.0/releases.json | jq -r '."latest-sdk"')
echo "dotnet_10_version=$DOTNET_10_VERSION" >> $GITHUB_OUTPUT
CSHARP_LS_VERSION=$(curl -s https://api.nuget.org/v3-flatcontainer/csharp-ls/index.json | jq -r '.versions[-1]')
echo "csharp_ls_version=$CSHARP_LS_VERSION" >> $GITHUB_OUTPUT
# Build all container images in parallel (each builds independently from node:20-slim)
build-images:
name: Build ${{ matrix.image }}
Expand Down Expand Up @@ -401,16 +405,16 @@ jobs:
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION"
- image: dotnet-10
dockerfile: ./docker/generated/Dockerfile.dotnet-10
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION"
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION\nCSHARP_LS_VERSION=$CSHARP_LS_VERSION"
- image: dotnet
dockerfile: ./docker/generated/Dockerfile.dotnet
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_8_VERSION=$DOTNET_8_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION"
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_8_VERSION=$DOTNET_8_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION\nCSHARP_LS_VERSION=$CSHARP_LS_VERSION"
- image: dotnet-playwright
dockerfile: ./docker/generated/Dockerfile.dotnet-playwright
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_8_VERSION=$DOTNET_8_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION\nPLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION"
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_8_VERSION=$DOTNET_8_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION\nPLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION\nCSHARP_LS_VERSION=$CSHARP_LS_VERSION"
- image: dotnet-rust
dockerfile: ./docker/generated/Dockerfile.dotnet-rust
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_8_VERSION=$DOTNET_8_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION"
build_args: "COPILOT_VERSION=$COPILOT_VERSION\nDOTNET_SDK_8_VERSION=$DOTNET_8_VERSION\nDOTNET_SDK_9_VERSION=$DOTNET_9_VERSION\nDOTNET_SDK_10_VERSION=$DOTNET_10_VERSION\nCSHARP_LS_VERSION=$CSHARP_LS_VERSION"
steps:
- name: Checkout repository
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
Expand All @@ -437,6 +441,7 @@ jobs:
ARGS="${ARGS//\$DOTNET_8_VERSION/${{ needs.prepare-versions.outputs.dotnet_8_version }}}"
ARGS="${ARGS//\$DOTNET_9_VERSION/${{ needs.prepare-versions.outputs.dotnet_9_version }}}"
ARGS="${ARGS//\$DOTNET_10_VERSION/${{ needs.prepare-versions.outputs.dotnet_10_version }}}"
ARGS="${ARGS//\$CSHARP_LS_VERSION/${{ needs.prepare-versions.outputs.csharp_ls_version }}}"
echo "build_args<<EOF" >> $GITHUB_OUTPUT
echo -e "$ARGS" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion docker/generated/Dockerfile.dotnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ RUN mkdir -p /etc/copilot/lsp-config.d && \
# --- snippet: lsp-csharp ---
# Install C# Language Server for code intelligence
# Install directly to a shared location so appuser can access it
ARG CSHARP_LS_VERSION=latest
ARG CSHARP_LS_VERSION=0.22.0
RUN dotnet tool install csharp-ls --tool-path /usr/local/bin --version ${CSHARP_LS_VERSION}

# Write LSP config fragment for C#
Expand Down
2 changes: 1 addition & 1 deletion docker/generated/Dockerfile.dotnet-10
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ RUN mkdir -p /etc/copilot/lsp-config.d && \
# --- snippet: lsp-csharp ---
# Install C# Language Server for code intelligence
# Install directly to a shared location so appuser can access it
ARG CSHARP_LS_VERSION=latest
ARG CSHARP_LS_VERSION=0.22.0
RUN dotnet tool install csharp-ls --tool-path /usr/local/bin --version ${CSHARP_LS_VERSION}

# Write LSP config fragment for C#
Expand Down
2 changes: 1 addition & 1 deletion docker/generated/Dockerfile.dotnet-playwright
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ RUN mkdir -p /etc/copilot/lsp-config.d && \
# --- snippet: lsp-csharp ---
# Install C# Language Server for code intelligence
# Install directly to a shared location so appuser can access it
ARG CSHARP_LS_VERSION=latest
ARG CSHARP_LS_VERSION=0.22.0
RUN dotnet tool install csharp-ls --tool-path /usr/local/bin --version ${CSHARP_LS_VERSION}

# Write LSP config fragment for C#
Expand Down
2 changes: 1 addition & 1 deletion docker/generated/Dockerfile.dotnet-rust
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ RUN mkdir -p /etc/copilot/lsp-config.d && \
# --- snippet: lsp-csharp ---
# Install C# Language Server for code intelligence
# Install directly to a shared location so appuser can access it
ARG CSHARP_LS_VERSION=latest
ARG CSHARP_LS_VERSION=0.22.0
RUN dotnet tool install csharp-ls --tool-path /usr/local/bin --version ${CSHARP_LS_VERSION}

# Write LSP config fragment for C#
Expand Down
2 changes: 1 addition & 1 deletion docker/snippets/lsp-csharp.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Install C# Language Server for code intelligence
# Install directly to a shared location so appuser can access it
ARG CSHARP_LS_VERSION=latest
ARG CSHARP_LS_VERSION=0.22.0
RUN dotnet tool install csharp-ls --tool-path /usr/local/bin --version ${CSHARP_LS_VERSION}

# Write LSP config fragment for C#
Expand Down
Loading