Skip to content

Update dependency urllib3 to v2 #14011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Update dependency urllib3 to v2 #14011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run/idp-sql/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ pg8000==1.31.5
gunicorn==23.0.0
firebase-admin==7.0.0
structlog==25.1.0
urllib3<2.0.0 #https://stackoverflow.com/questions/76175361/firebase-authentication-httpresponse-object-has-no-attribute-strict-status
urllib3<2.6.4 #https://stackoverflow.com/questions/76175361/firebase-authentication-httpresponse-object-has-no-attribute-strict-status
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment referencing the StackOverflow issue is now misleading and contradictory. The linked issue explains why urllib3 was restricted to versions below 2.0.0. Since this PR updates the dependency to allow version 2 (which is compatible with firebase-admin v7.0.0), the comment should be removed. Additionally, to ensure the application actually uses version 2 and incorporates the security fixes mentioned in the release notes (e.g., the decompression bomb fixes in v2.6.0 and the redirect fix in v2.6.3), it is recommended to add a lower bound to the version constraint.

urllib3>=2.6.3,<2.6.4