-
Notifications
You must be signed in to change notification settings - Fork 6.7k
chore: migrate cleanup commands from gsutil to gcloud storage #13732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: migrate cleanup commands from gsutil to gcloud storage #13732
Conversation
Summary of ChangesHello @bhandarivijay-png, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates a Google Cloud Storage cleanup command within the test configuration to use the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates a gsutil command to its gcloud storage equivalent for cleaning up a GCS bucket in a test fixture. The change is correct, but I've suggested a small improvement to align with the idiomatic usage of the gcloud storage rm command, making the code cleaner and more aligned with official documentation.
| # Deleting a bucket with too many files results in an error. | ||
| try: | ||
| run_cmd("gsutil", "-m", "rm", "-rf", f"gs://{bucket_name}/*") | ||
| run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}/**") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity and to follow documented best practices, you can remove the /** wildcard. The gcloud storage rm --recursive command, when applied to a bucket URL, is sufficient to delete all objects within it.
The official documentation and migration guides recommend gcloud storage rm gs://my-bucket --recursive as the idiomatic way to empty a bucket. This makes the command cleaner.
| run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}/**") | |
| run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}") |
chore: migrate cleanup commands from gsutil to gcloud storage