Skip to content

Conversation

@bhandarivijay-png
Copy link

@bhandarivijay-png bhandarivijay-png commented Jan 9, 2026

chore: migrate cleanup commands from gsutil to gcloud storage

@bhandarivijay-png bhandarivijay-png requested review from a team as code owners January 9, 2026 16:39
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: people-and-planet-ai labels Jan 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bhandarivijay-png, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates a Google Cloud Storage cleanup command within the test configuration to use the gcloud storage command-line interface instead of the legacy gsutil utility. This change aligns with modern Google Cloud practices, promoting the use of the unified gcloud CLI for managing cloud resources and ensuring consistency across command-line operations.

Highlights

  • Command Migration: Migrated the Google Cloud Storage bucket cleanup command from gsutil to gcloud storage in people-and-planet-ai/conftest.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates a gsutil command to its gcloud storage equivalent for cleaning up a GCS bucket in a test fixture. The change is correct, but I've suggested a small improvement to align with the idiomatic usage of the gcloud storage rm command, making the code cleaner and more aligned with official documentation.

# Deleting a bucket with too many files results in an error.
try:
run_cmd("gsutil", "-m", "rm", "-rf", f"gs://{bucket_name}/*")
run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}/**")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to follow documented best practices, you can remove the /** wildcard. The gcloud storage rm --recursive command, when applied to a bucket URL, is sufficient to delete all objects within it.

The official documentation and migration guides recommend gcloud storage rm gs://my-bucket --recursive as the idiomatic way to empty a bucket. This makes the command cleaner.

Suggested change
run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}/**")
run_cmd("gcloud", "storage", "rm", "--recursive", f"gs://{bucket_name}")

@bhandarivijay-png bhandarivijay-png requested a review from a team as a code owner January 9, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: people-and-planet-ai samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant