Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion error_reporting/composer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"require": {
"google/cloud-error-reporting": "^0.25.0"
"google/cloud-error-reporting": "^0.26.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating google/cloud-error-reporting to v0.26.0 introduces a breaking change that will cause your tests to fail.

The release notes for v0.26.0 state:

⚠ BREAKING CHANGES

  • [ErrorReporting] remove deprecated GAPICs

Your test code in error_reporting/test/VerifyReportedErrorTrait.php uses Google\Cloud\ErrorReporting\V1beta1\ErrorStatsServiceClient, which is one of the clients that has been removed in this new version.

To fix this, you need to update error_reporting/test/VerifyReportedErrorTrait.php to use the new client from the Client namespace. The use statement should be changed from:

use Google\Cloud\ErrorReporting\V1beta1\ErrorStatsServiceClient;

to:

use Google\Cloud\ErrorReporting\V1beta1\Client\ErrorStatsServiceClient;

Since this PR does not include the necessary code changes to adapt to this breaking change, merging it will break the build. Please update this PR to include the fix in the test files.

}
}
Loading