test(contact-center-insights): add delay to createAnalysis test to ensure conversation readiness#4322
Open
angelcaamal wants to merge 9 commits into
Open
test(contact-center-insights): add delay to createAnalysis test to ensure conversation readiness#4322angelcaamal wants to merge 9 commits into
angelcaamal wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a 10-second delay in the createAnalysis.test.js file to ensure conversations are ready before analysis. Feedback suggests replacing the raw setTimeout with the project's existing delay helper function to maintain consistency and leverage its built-in backoff logic.
- Intercept gRPC error 13 (INTERNAL) in createAnalysis test to skip execution and avoid false red pipelines. - Keep default retry behavior for quota or other transient errors. - Reduce initial setTimeout delay from 65s to 5s to optimize CI speed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Flaky CI Pipeline for CreateAnalysis
Context & Problem
Our CI pipeline has been experiencing intermittent failures during the CreateAnalysis step. We identified two main issues blocking our builds:
Changes Made
createAnalysis.js
test/createAnalysis.test.js
Fixes Internal: b/516854680
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.