fix(genai): resolve module path and naming issues in count-tokens samples#4321
Open
angelcaamal wants to merge 2 commits into
Open
fix(genai): resolve module path and naming issues in count-tokens samples#4321angelcaamal wants to merge 2 commits into
angelcaamal wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates test files to align with renamed source files and the standardized countTokens function. A review comment identifies an inconsistency in the require statements where the .js extension was omitted in one file but retained in another, suggesting its restoration for repository-wide consistency.
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses execution errors in the genai/count-tokens test suite.
Changes:
Path Corrections: Updated require statements in test files to correctly point to the corresponding sample source files.
Fixes Internal: b/517253756
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.