Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in searchFhirResourcesGet.js#4233

Merged
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-search-resources-get
Feb 26, 2026
Merged

fix(healthcare): set responseType to JSON instead of Buffer in searchFhirResourcesGet.js#4233
iennae merged 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-search-resources-get

Conversation

@angelcaamal
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. labels Feb 25, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @angelcaamal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the searchFhirResourcesGet.js sample by explicitly configuring the API request to expect a JSON response. This change is crucial for correctly processing the returned FHIR resources, preventing potential data parsing errors that might occur if the response was treated as a buffer and ensuring the sample functions as intended.

Highlights

  • API Response Handling: Modified the 'searchFhirResourcesGet.js' sample to explicitly set the 'responseType' to 'json' for API requests, ensuring proper parsing of the FHIR resource data.
Changelog
  • healthcare/fhir/searchFhirResourcesGet.js
    • Explicitly set the 'responseType' to 'json' for the client request.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue in searchFhirResourcesGet.js by explicitly setting the responseType to json in the client.request call. This ensures the response from the Healthcare API is properly parsed as JSON, preventing potential errors when accessing the response data. While reviewing this change, I noticed that healthcare/fhir/searchFhirResourcesPost.js contains similar logic but also appears to be missing the responseType: 'json' parameter. It would be beneficial to apply a similar fix to that file to ensure consistent and correct behavior for both GET and POST search methods.

@angelcaamal angelcaamal marked this pull request as ready for review February 25, 2026 19:47
@angelcaamal angelcaamal requested review from a team as code owners February 25, 2026 19:47
@iennae iennae merged commit 553cffd into GoogleCloudPlatform:main Feb 26, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healhcare api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants