Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in executeFhirBundle.js#4231

Open
angelcaamal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-execute-bundle
Open

fix(healthcare): set responseType to JSON instead of Buffer in executeFhirBundle.js#4231
angelcaamal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-execute-bundle

Conversation

@angelcaamal
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. labels Feb 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @angelcaamal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the executeFhirBundle.js sample by ensuring that API responses are correctly parsed as JSON and improving the readability of the output. By explicitly configuring the response type and formatting the console log, the sample now provides a more robust and user-friendly experience when executing FHIR bundles.

Highlights

  • API Client Configuration: Explicitly set the responseType to 'json' for the API client in executeFhirBundle.js to ensure proper handling of JSON responses.
  • Output Formatting: Updated the console logging of the FHIR bundle execution result to pretty-print the JSON data using JSON.stringify for better readability.
Changelog
  • healthcare/fhir/executeFhirBundle.js
    • Added responseType: 'json' to the API client configuration.
    • Modified console.log(resource.data) to console.log(JSON.stringify(resource.data, null, 2)) for formatted output.
Activity
  • The pull request was opened by angelcaamal.
  • No human comments or reviews have been made on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates executeFhirBundle.js to set the response type to json and pretty-prints the output. The changes are functionally correct. My review includes a suggestion to improve the robustness of the sample by adding error handling for the asynchronous operations.

);
console.log('FHIR bundle executed');
console.log(resource.data);
console.log(JSON.stringify(resource.data, null, 2));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This function contains asynchronous operations (file reading, API call) that can fail. Without a try...catch block, any error will result in an unhandled promise rejection, which can crash the application in future Node.js versions. To make this sample more robust and user-friendly, please wrap the function body in a try...catch block to handle potential errors gracefully.

@angelcaamal angelcaamal marked this pull request as ready for review February 24, 2026 23:55
@angelcaamal angelcaamal requested review from a team as code owners February 24, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant