Fix SQL Server Entra ID user matching in google_sql_user - #18794
Draft
ajupazhamayil wants to merge 1 commit into
Draft
Fix SQL Server Entra ID user matching in google_sql_user#18794ajupazhamayil wants to merge 1 commit into
ajupazhamayil wants to merge 1 commit into
Conversation
modular-magician
added
the
awaiting-approval
ajupazhamayil
force-pushed
the
fix-sqlserver-entraid-user
branch
from
August 26, 2026 12:01
16a1070 to
bedca96
Compare
Exempt ENTRAID_USER from strings.Split in resourceSqlUserRead so full email UPN names are preserved and matched against Cloud SQL API responses. Also document ENTRAID_USER for SQL Server in sql_user documentation.
ajupazhamayil
force-pushed
the
fix-sqlserver-entraid-user
branch
from
August 26, 2026 13:04
bedca96 to
d413316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where creating a Cloud SQL SQL Server Entra ID user (
type = "ENTRAID_USER") fails on refresh withRoot object was present, but now absent.resourceSqlUserReadwas stripping@domainusingstrings.Split(name, "@")[0]for all non-Postgres engines.For email-based Entra ID users (e.g.
user@tenant.onmicrosoft.com), this causs name matching to fail against the API response.This change exempts
ENTRAID_USERfrom domain stripping so the full email names is preserved.Tests
ENTRAID_USER).ENTRAID_USERrequire pre-provisioned Azure Active Directory certificates and tenant configuration on the instance, so end-to-end testing was performed manually.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.