Skip to content

observability: add google_observability_bucket resource - #18790

Open
ScottSuarez wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ScottSuarez:add_google_observability_bucket_terraform
Open

observability: add google_observability_bucket resource#18790
ScottSuarez wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ScottSuarez:add_google_observability_bucket_terraform

Conversation

@ScottSuarez

Copy link
Copy Markdown
Contributor

Adds Terraform support for google_observability_bucket.

Reference: b/546650516

`google_observability_bucket`

@ScottSuarez
ScottSuarez force-pushed the add_google_observability_bucket_terraform branch 2 times, most recently from b304631 to 89aff0b Compare August 25, 2026 21:02
@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f46c527:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 222 insertions(+)
google-beta provider View Diff 4 files changed, 1165 insertions(+)
terraform-google-conversion View Diff 1 file changed, 189 insertions(+)

Missing ResourceIdentity coverage

Your PR includes resources that declare ResourceIdentity but are missing identity handling.

Resource: google_observability_bucket

  • Missing SetResourceIdentityAttributes in: Create, Read, Update
  • Missing import identity test (TestAcc..._importBlockWithResourceIdentity)

An override-missing-identity label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
18 17 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityBucket_observabilityBucketBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccObservabilityBucket_observabilityBucketBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for f46c527!

@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b304631:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 222 insertions(+)
google-beta provider View Diff 4 files changed, 1165 insertions(+)
terraform-google-conversion View Diff 1 file changed, 189 insertions(+)

Missing ResourceIdentity coverage

Your PR includes resources that declare ResourceIdentity but are missing identity handling.

Resource: google_observability_bucket

  • Missing SetResourceIdentityAttributes in: Create, Read, Update
  • Missing import identity test (TestAcc..._importBlockWithResourceIdentity)

An override-missing-identity label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
18 17 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityBucket_observabilityBucketBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccObservabilityBucket_observabilityBucketBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for b304631!

@ScottSuarez
ScottSuarez force-pushed the add_google_observability_bucket_terraform branch from 89aff0b to 94ac2c4 Compare August 25, 2026 21:08
@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 89aff0b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1153 insertions(+)
google-beta provider View Diff 4 files changed, 1153 insertions(+)
terraform-google-conversion View Diff 1 file changed, 189 insertions(+)

Missing ResourceIdentity coverage

Your PR includes resources that declare ResourceIdentity but are missing identity handling.

Resource: google_observability_bucket

  • Missing SetResourceIdentityAttributes in: Create, Read, Update
  • Missing import identity test (TestAcc..._importBlockWithResourceIdentity)

An override-missing-identity label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityBucket_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccObservabilityBucket_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 89aff0b!

@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 94ac2c4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1363 insertions(+)
google-beta provider View Diff 5 files changed, 1363 insertions(+)
terraform-google-conversion View Diff 1 file changed, 189 insertions(+)

Missing ResourceIdentity coverage

Your PR includes resources that declare ResourceIdentity but are missing identity handling.

Resource: google_observability_bucket

  • Missing SetResourceIdentityAttributes in: Create, Read, Update
  • Missing import identity test (TestAcc..._importBlockWithResourceIdentity)

An override-missing-identity label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityBucket_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccObservabilityBucket_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 94ac2c4!

@ScottSuarez
ScottSuarez force-pushed the add_google_observability_bucket_terraform branch from 94ac2c4 to 831646f Compare August 25, 2026 21:44
@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 831646f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1246 insertions(+)
google-beta provider View Diff 5 files changed, 1246 insertions(+)
terraform-google-conversion View Diff 1 file changed, 189 insertions(+)

Missing ResourceIdentity coverage

Your PR includes resources that declare ResourceIdentity but are missing identity handling.

Resource: google_observability_bucket

  • Missing SetResourceIdentityAttributes in: Create, Read, Update
  • Missing import identity test (TestAcc..._importBlockWithResourceIdentity)

An override-missing-identity label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccObservabilityBucket_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccObservabilityBucket_update

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ScottSuarez VCR tests complete for 831646f!

@ScottSuarez
ScottSuarez force-pushed the add_google_observability_bucket_terraform branch from 831646f to 65b880a Compare August 26, 2026 17:25
@ScottSuarez

Copy link
Copy Markdown
Contributor Author

/gcbrun

@modular-magician

modular-magician commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 65b880a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1154 insertions(+)
google-beta provider View Diff 4 files changed, 1154 insertions(+)
terraform-google-conversion View Diff 1 file changed, 189 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
18 18 0 0
Affected Service Packages
  • observability

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@ScottSuarez VCR tests complete for 65b880a!

@ScottSuarez

Copy link
Copy Markdown
Contributor Author

@modular-magician assign-reviewer

For this resource, only one _trace can exist on a project at a time. There is no delete for this resource. We are always updating the existing one in place if we find it.

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from slevenick August 26, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants