Skip to content

Add missing fields to google_ces_app - #18787

Open
xubolyu-google wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
xubolyu-google:add-ces-app-fields
Open

Add missing fields to google_ces_app#18787
xubolyu-google wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
xubolyu-google:add-ces-app-fields

Conversation

@xubolyu-google

Copy link
Copy Markdown

Description:
Add missing public fields to google_ces_app according to google/cloud/ces/v1main/app.proto:

  • dashboard_settings
  • error_handling_settings
  • evaluation_personas
  • evaluation_settings
  • locked
  • vpc_sc_settings
  • logging_settings.conversation_logging_settings.retention_window
  • predefined_variable_declarations (output only)
  • validation_errors (output only)

Issue: https://b.corp.google.com/issues/534420948

ces: added `dashboard_settings`, `error_handling_settings`, `evaluation_personas`, `evaluation_settings`, `locked`, `vpc_sc_settings`, `predefined_variable_declarations`, and `validation_errors` fields to `google_ces_app`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 25, 2026
@github-actions
github-actions Bot requested a review from ScottSuarez August 25, 2026 18:41
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Removed duplicated error handling settings and related properties from App.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants