Skip to content

networkservices: add agent_connectivity_template to google_network_services_agent_gateway - #18784

Open
melinath wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
melinath:mm-b-548696678
Open

networkservices: add agent_connectivity_template to google_network_services_agent_gateway#18784
melinath wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
melinath:mm-b-548696678

Conversation

@melinath

Copy link
Copy Markdown
Member

Add agent_connectivity_template field to google_network_services_agent_gateway.

Fixes https://b.corp.google.com/issues/548696678

networkservices: added `agent_connectivity_template` field to `google_network_services_agent_gateway`

@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 489424c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 42 insertions(+)
google-beta provider View Diff 3 files changed, 42 insertions(+)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_agent_gateway (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_agent_gateway" "primary" {
  agent_connectivity_template = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
112 110 2 0
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@melinath VCR tests complete for 489424c!

@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 83fd65b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 197 insertions(+), 1 deletion(-)
google-beta provider View Diff 4 files changed, 197 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccNetworkServicesAgentGateway_networkServicesAgentGatewayAgentConnectivityTemplateUpdate

Analytics

Total Tests Passed Skipped Affected
113 110 3 0
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@melinath VCR tests complete for 83fd65b!

@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d600577:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 273 insertions(+), 1 deletion(-)
google-beta provider View Diff 4 files changed, 273 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
113 110 2 1
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesAgentGateway_networkServicesAgentGatewayAgentConnectivityTemplateUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccNetworkServicesAgentGateway_networkServicesAgentGatewayAgentConnectivityTemplateUpdate

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for d600577!

@modular-magician

modular-magician commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9dbdd46:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 273 insertions(+), 1 deletion(-)
google-beta provider View Diff 4 files changed, 273 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
113 111 2 0
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@melinath VCR tests complete for 9dbdd46!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants